Skip to content

Re-configure GitLab deployment jobs#11757

Open
sarahchen6 wants to merge 1 commit into
masterfrom
sarahchen6/maven-deployment-dependencies-adjustment
Open

Re-configure GitLab deployment jobs#11757
sarahchen6 wants to merge 1 commit into
masterfrom
sarahchen6/maven-deployment-dependencies-adjustment

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Reconfigure Maven and GitHub deployment jobs to run after GitLab system-tests succeed.

OCI publishing and GitHub deployments both depend on Maven publishing to first succeed. GitLab system-tests and OCI image publishing are in the same shared-pipeline stage. Thus, for system-tests->Maven->GitHub,OCI dependency chain to work, they all need to be within the same shared-pipeline stage.

Motivation

In release 1.63.1 where GitLab system-tests failed, Maven and GitHub artifacts were deployed while OCI artifacts were not because only OCI artifacts depended on system-tests success.

Additional Notes

Check the effects of the changes in this PR by going to the GitLab pipeline, clicking "Job dependencies" and toggling "Show dependencies" (https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/121395706).

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 26, 2026
@sarahchen6 sarahchen6 marked this pull request as ready for review June 26, 2026 21:36
@sarahchen6 sarahchen6 requested review from a team as code owners June 26, 2026 21:36
@sarahchen6 sarahchen6 requested review from bric3 and randomanderson and removed request for a team June 26, 2026 21:36
@dd-octo-sts

dd-octo-sts Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.81 s 14.71 s [-0.2%; +1.6%] (no difference)
startup:insecure-bank:tracing:Agent 13.62 s 13.62 s [-0.9%; +1.0%] (no difference)
startup:petclinic:appsec:Agent 16.89 s 16.87 s [-1.1%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.87 s 16.92 s [-1.3%; +0.8%] (no difference)
startup:petclinic:profiling:Agent 16.34 s 16.97 s [-8.1%; +0.7%] (no difference)
startup:petclinic:sca:Agent 16.88 s 16.56 s [+0.9%; +3.0%] (maybe worse)
startup:petclinic:tracing:Agent 15.71 s 15.67 s [-5.7%; +6.2%] (unstable)

Commit: 61415d5d · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant