Allow Maven deployment to fail

[sarahchen6]

What Does This Do

Allow Maven Central deployment job to fail.

The result of this change is that the verify_maven_central_deployment job that depends on deploy_to_maven_central will run as long as deploy_to_maven_central completes. Without this change, the verify_maven_central_deployment job only runs if deploy_to_maven_central succeeds.

Motivation

With the 1.63.1 patch release, pipeline failures resulted in the successful publishing of artifacts onto Maven Central but not of OCI images. Also, OCI image publishing is gated via a publishing-job that is gated by Maven Central deployment verification.

After fixing the pipeline issue, we wanted to re-run the pipeline and override the Maven Central deployment verification to allow the OCI publishing. This should be possible with the manually triggered override_verify_maven_central job, but since deploy_to_maven_central failed (release already exists), verify_maven_central_deployment could never run.

By allowing the deployment to fail and the verification to run regardless, the override should now work.

Additional Notes

If the override job is not run and the initial deployment fails, the verification would run and still fail as well, still properly gating the publishing-gate.

The Maven Central publishing jobs only run on protected git tags.

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Add your completed PR to the merge queue by commenting /merge. You can also:
  • Customize the commit message associated with the merge with /merge --commit-message "..."
  • Remove your PR from the merge queue with /merge -c
  • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
  • Get more information in this doc

Jira ticket: [PROJ-IDENT]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10f13a0ee9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Disable artifact download for failed Maven deploy

With this rule the tag deploy can finish as an allowed failure, but verify_maven_central_deployment still uses needs: [ deploy_to_maven_central ], which defaults to downloading artifacts, while deploy_to_maven_central only uploads its artifacts on success. In the rerun/“release already exists” path this is meant to unblock, a failed deploy has no successful artifact archive, so the verify job can fail before its script reads OVERRIDE_MAVEN_VERIFY and the publishing gate remains blocked; make the verify need use artifacts: false or otherwise upload artifacts on failure.

Useful? React with 👍 / 👎.

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.91 s	13.91 s	[-0.7%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent	12.84 s	13.00 s	[-2.2%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent	16.94 s	16.74 s	[+0.2%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent	16.91 s	16.92 s	[-0.9%; +0.9%] (no difference)
startup:petclinic:profiling:Agent	16.28 s	16.47 s	[-7.3%; +5.0%] (unstable)
startup:petclinic:sca:Agent	16.90 s	16.77 s	[-0.0%; +1.7%] (no difference)
startup:petclinic:tracing:Agent	16.04 s	15.59 s	[-1.3%; +7.1%] (no difference)

Commit: 10f13a0e · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.