Add profiler integration for wall-clock signal suppression and TaskBlock events#11247
Draft
Add profiler integration for wall-clock signal suppression and TaskBlock events#11247
Conversation
bf909b9 to
769b169
Compare
e60eeb3 to
e2f9451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
ProfilingContextIntegrationhooks (ticks, TaskBlock, park enter/exit) and wiresDatadogProfilingIntegration->JavaProfiler.ProfilingDdprofWallClockBridge: ifgetProfilingContext()is null onparkexit, still call nativeparkExit(registered fromDatadogProfilingIntegration).LockSupport: instrumentpark*/unparkparkEnteralways (span optional); actual TaskBlock recording happens insidejava-profiler.Object.wait(long)(JDK 21+): may emitTaskBlockafter >= 1 ms;unblockingSpanIdstays 0.lock-support-profiling,object-wait-profiling+ tests.Motivation
java-profilerchanges suppress redundant wall-clock signals while blocked (sleep / park) and recorddatadog.TaskBlockfor analysis. The agent must call those JNI hooks with ticks and span context so suppression and TaskBlock events work end-to-end without dropping correctness.Additional Notes
java-profilermust ship the matchingddprofartifact (JNI + native).encode/encodeOperationName/encodeResourceNamebehavior remains 0 for ddprof (same as priorProfilingContextIntegrationdefaults); comment clarifies intent.Object.wait: onlywait(long)is instrumented.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket:
[PROJ-IDENT]Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.