refactor(openfeature): use ffe-system-test-data submodule for UFC fixtures#10977
Draft
leoromanovsky wants to merge 5 commits intomasterfrom
Draft
refactor(openfeature): use ffe-system-test-data submodule for UFC fixtures#10977leoromanovsky wants to merge 5 commits intomasterfrom
leoromanovsky wants to merge 5 commits intomasterfrom
Conversation
…ng TARGETING_MATCH - Add Split parameter to resolveVariant for three-way reason computation - Return STATIC for flags with no rules and no shards (simple flags) - Return SPLIT for flags with no rules but with shards (shard-based flags) - Return TARGETING_MATCH for flags with rules (rule-based flags) - Update 9 test assertions: 7 to STATIC, 2 to SPLIT
- Add ufc-config.json (canonical server configuration) - Add 24 evaluation-case JSON files from dd-trace-go - Files are byte-identical copies of Go reference fixtures
…cal cases - JUnit 5 @testfactory generates dynamic tests from 24 evaluation-case JSON files - Parses ufc-config.json into ServerConfiguration using Moshi with DateAdapter - Asserts both value and reason for each fixture case - Handles Java/Go divergences: Java returns ERROR where Go returns DEFAULT for missing flags and empty allocations - Skips null attribute values in context building (null = missing)
- Add ffe-system-test-data as git submodule in test resources - Update DDEvaluatorFixtureTest to read from submodule path - Delete old local copies of ufc-config.json and evaluation-cases/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stacked on #10971. Replaces local fixture copies with a git submodule pointing at
ffe-system-test-data— single source of truth for UFC evaluation fixtures across all SDKs.Changes
ffe-system-test-dataas git submodule in test resourcesDDEvaluatorFixtureTest.javato read from submodule pathDecisions