Run aggregate_test_counts job on Merge Queue#10954
Run aggregate_test_counts job on Merge Queue#10954gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
| - if: '$CI_COMMIT_BRANCH =~ /^gh-readonly-queue/' | ||
| when: on_success |
There was a problem hiding this comment.
Somehow I feel this will be never executed? Or am I missing something?
My understanding that GH MQ simply redirects to DD MQ, is that correct?
Also I feel that we may run this on master, but not 100% sure.
There was a problem hiding this comment.
It's already too late on master only. The idea is to detect early, before impacting master.
There was a problem hiding this comment.
It could be helpful to have it on master so that we can check what the baseline test count is? For example when comparing your PR's test count to what the "original" master test count is.
And yep the GH MQ line should never run, but we set it for all tests as a catch-all here: https://github.com/DataDog/dd-trace-java/blob/master/.gitlab-ci.yml#L596, so I thought we might as well have it here too.
There was a problem hiding this comment.
It's already too late on master only. The idea is to detect early, before impacting master.
My bad, I ment and on master too :)
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063993
Total [baseline] (8.875 s) : 0, 8874892
Agent [candidate] (1.058 s) : 0, 1057666
Total [candidate] (8.838 s) : 0, 8837796
section iast
Agent [baseline] (1.242 s) : 0, 1242278
Total [baseline] (9.616 s) : 0, 9616025
Agent [candidate] (1.239 s) : 0, 1238769
Total [candidate] (9.572 s) : 0, 9571831
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (632.999 ms) : 0, 632999
BytebuddyAgent [candidate] (628.709 ms) : 0, 628709
AgentMeter [baseline] (29.642 ms) : 0, 29642
AgentMeter [candidate] (29.421 ms) : 0, 29421
GlobalTracer [baseline] (257.998 ms) : 0, 257998
GlobalTracer [candidate] (256.681 ms) : 0, 256681
AppSec [baseline] (32.032 ms) : 0, 32032
AppSec [candidate] (31.667 ms) : 0, 31667
Debugger [baseline] (59.945 ms) : 0, 59945
Debugger [candidate] (59.619 ms) : 0, 59619
Remote Config [baseline] (593.169 µs) : 0, 593
Remote Config [candidate] (583.163 µs) : 0, 583
Telemetry [baseline] (8.897 ms) : 0, 8897
Telemetry [candidate] (9.522 ms) : 0, 9522
Flare Poller [baseline] (4.417 ms) : 0, 4417
Flare Poller [candidate] (4.249 ms) : 0, 4249
section iast
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (807.443 ms) : 0, 807443
BytebuddyAgent [candidate] (805.024 ms) : 0, 805024
AgentMeter [baseline] (11.862 ms) : 0, 11862
AgentMeter [candidate] (11.518 ms) : 0, 11518
GlobalTracer [baseline] (249.527 ms) : 0, 249527
GlobalTracer [candidate] (249.136 ms) : 0, 249136
AppSec [baseline] (26.977 ms) : 0, 26977
AppSec [candidate] (27.022 ms) : 0, 27022
Debugger [baseline] (68.013 ms) : 0, 68013
Debugger [candidate] (66.956 ms) : 0, 66956
Remote Config [baseline] (532.011 µs) : 0, 532
Remote Config [candidate] (511.947 µs) : 0, 512
Telemetry [baseline] (10.775 ms) : 0, 10775
Telemetry [candidate] (11.231 ms) : 0, 11231
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (3.968 ms) : 0, 3968
IAST [baseline] (25.756 ms) : 0, 25756
IAST [candidate] (25.817 ms) : 0, 25817
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071022
Total [baseline] (11.109 s) : 0, 11109464
Agent [candidate] (1.06 s) : 0, 1059664
Total [candidate] (11.09 s) : 0, 11089766
section appsec
Agent [baseline] (1.247 s) : 0, 1246673
Total [baseline] (11.142 s) : 0, 11141666
Agent [candidate] (1.245 s) : 0, 1244926
Total [candidate] (11.1 s) : 0, 11099810
section iast
Agent [baseline] (1.226 s) : 0, 1226474
Total [baseline] (11.311 s) : 0, 11310764
Agent [candidate] (1.239 s) : 0, 1238554
Total [candidate] (11.364 s) : 0, 11363663
section profiling
Agent [baseline] (1.183 s) : 0, 1183273
Total [baseline] (11.051 s) : 0, 11051361
Agent [candidate] (1.184 s) : 0, 1184383
Total [candidate] (10.959 s) : 0, 10959184
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (637.707 ms) : 0, 637707
BytebuddyAgent [candidate] (628.853 ms) : 0, 628853
AgentMeter [baseline] (29.851 ms) : 0, 29851
AgentMeter [candidate] (29.313 ms) : 0, 29313
GlobalTracer [baseline] (260.1 ms) : 0, 260100
GlobalTracer [candidate] (256.569 ms) : 0, 256569
AppSec [baseline] (32.184 ms) : 0, 32184
AppSec [candidate] (31.693 ms) : 0, 31693
Debugger [baseline] (61.31 ms) : 0, 61310
Debugger [candidate] (60.233 ms) : 0, 60233
Remote Config [baseline] (600.034 µs) : 0, 600
Remote Config [candidate] (590.872 µs) : 0, 591
Telemetry [baseline] (8.174 ms) : 0, 8174
Telemetry [candidate] (7.962 ms) : 0, 7962
Flare Poller [baseline] (3.626 ms) : 0, 3626
Flare Poller [candidate] (7.301 ms) : 0, 7301
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (658.881 ms) : 0, 658881
BytebuddyAgent [candidate] (658.574 ms) : 0, 658574
AgentMeter [baseline] (12.079 ms) : 0, 12079
AgentMeter [candidate] (12.069 ms) : 0, 12069
GlobalTracer [baseline] (257.742 ms) : 0, 257742
GlobalTracer [candidate] (257.511 ms) : 0, 257511
IAST [baseline] (24.204 ms) : 0, 24204
IAST [candidate] (24.075 ms) : 0, 24075
AppSec [baseline] (177.642 ms) : 0, 177642
AppSec [candidate] (177.036 ms) : 0, 177036
Debugger [baseline] (66.112 ms) : 0, 66112
Debugger [candidate] (65.747 ms) : 0, 65747
Remote Config [baseline] (622.002 µs) : 0, 622
Remote Config [candidate] (629.424 µs) : 0, 629
Telemetry [baseline] (8.31 ms) : 0, 8310
Telemetry [candidate] (8.259 ms) : 0, 8259
Flare Poller [baseline] (3.57 ms) : 0, 3570
Flare Poller [candidate] (3.53 ms) : 0, 3530
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (794.901 ms) : 0, 794901
BytebuddyAgent [candidate] (803.785 ms) : 0, 803785
AgentMeter [baseline] (11.398 ms) : 0, 11398
AgentMeter [candidate] (11.733 ms) : 0, 11733
GlobalTracer [baseline] (246.872 ms) : 0, 246872
GlobalTracer [candidate] (249.409 ms) : 0, 249409
IAST [baseline] (25.326 ms) : 0, 25326
IAST [candidate] (25.593 ms) : 0, 25593
AppSec [baseline] (26.519 ms) : 0, 26519
AppSec [candidate] (26.832 ms) : 0, 26832
Debugger [baseline] (70.992 ms) : 0, 70992
Debugger [candidate] (70.099 ms) : 0, 70099
Remote Config [baseline] (536.237 µs) : 0, 536
Remote Config [candidate] (523.268 µs) : 0, 523
Telemetry [baseline] (9.263 ms) : 0, 9263
Telemetry [candidate] (9.662 ms) : 0, 9662
Flare Poller [baseline] (3.379 ms) : 0, 3379
Flare Poller [candidate] (3.48 ms) : 0, 3480
section profiling
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (682.683 ms) : 0, 682683
BytebuddyAgent [candidate] (684.086 ms) : 0, 684086
AgentMeter [baseline] (9.01 ms) : 0, 9010
AgentMeter [candidate] (8.993 ms) : 0, 8993
GlobalTracer [baseline] (215.657 ms) : 0, 215657
GlobalTracer [candidate] (215.613 ms) : 0, 215613
AppSec [baseline] (32.22 ms) : 0, 32220
AppSec [candidate] (32.185 ms) : 0, 32185
Debugger [baseline] (65.141 ms) : 0, 65141
Debugger [candidate] (63.532 ms) : 0, 63532
Remote Config [baseline] (558.612 µs) : 0, 559
Remote Config [candidate] (568.555 µs) : 0, 569
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (9.987 ms) : 0, 9987
Flare Poller [baseline] (4.164 ms) : 0, 4164
Flare Poller [candidate] (3.474 ms) : 0, 3474
ProfilingAgent [baseline] (93.967 ms) : 0, 93967
ProfilingAgent [candidate] (93.758 ms) : 0, 93758
Profiling [baseline] (94.529 ms) : 0, 94529
Profiling [candidate] (94.315 ms) : 0, 94315
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1169, 1193
. : milestone, 1181,
iast (3.275 ms) : 3236, 3315
. : milestone, 3275,
iast_FULL (5.904 ms) : 5844, 5964
. : milestone, 5904,
iast_GLOBAL (3.666 ms) : 3605, 3728
. : milestone, 3666,
profiling (1.921 ms) : 1905, 1937
. : milestone, 1921,
tracing (1.804 ms) : 1788, 1820
. : milestone, 1804,
section candidate
no_agent (1.181 ms) : 1169, 1192
. : milestone, 1181,
iast (3.076 ms) : 3035, 3118
. : milestone, 3076,
iast_FULL (5.773 ms) : 5715, 5830
. : milestone, 5773,
iast_GLOBAL (3.554 ms) : 3498, 3610
. : milestone, 3554,
profiling (1.926 ms) : 1910, 1942
. : milestone, 1926,
tracing (1.823 ms) : 1808, 1839
. : milestone, 1823,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (17.36 ms) : 17186, 17533
. : milestone, 17360,
appsec (18.843 ms) : 18651, 19034
. : milestone, 18843,
code_origins (19.763 ms) : 19568, 19958
. : milestone, 19763,
iast (17.757 ms) : 17578, 17936
. : milestone, 17757,
profiling (18.523 ms) : 18337, 18710
. : milestone, 18523,
tracing (17.657 ms) : 17483, 17831
. : milestone, 17657,
section candidate
no_agent (17.913 ms) : 17728, 18099
. : milestone, 17913,
appsec (18.622 ms) : 18437, 18808
. : milestone, 18622,
code_origins (17.73 ms) : 17553, 17907
. : milestone, 17730,
iast (17.541 ms) : 17366, 17715
. : milestone, 17541,
profiling (18.727 ms) : 18540, 18914
. : milestone, 18727,
tracing (17.659 ms) : 17483, 17835
. : milestone, 17659,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.839 ms) : 3615, 4063
. : milestone, 3839,
iast (2.263 ms) : 2194, 2331
. : milestone, 2263,
iast_GLOBAL (2.308 ms) : 2238, 2377
. : milestone, 2308,
profiling (2.094 ms) : 2040, 2149
. : milestone, 2094,
tracing (2.082 ms) : 2028, 2135
. : milestone, 2082,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.83 ms) : 3606, 4053
. : milestone, 3830,
iast (2.263 ms) : 2194, 2331
. : milestone, 2263,
iast_GLOBAL (2.314 ms) : 2245, 2384
. : milestone, 2314,
profiling (2.109 ms) : 2052, 2165
. : milestone, 2109,
tracing (2.065 ms) : 2011, 2118
. : milestone, 2065,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f7c8b3f0a6, baseline=1.61.0-SNAPSHOT~68aa369a4f
dateFormat X
axisFormat %s
section baseline
no_agent (15.474 s) : 15474000, 15474000
. : milestone, 15474000,
appsec (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
iast (17.953 s) : 17953000, 17953000
. : milestone, 17953000,
iast_GLOBAL (17.682 s) : 17682000, 17682000
. : milestone, 17682000,
profiling (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
tracing (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
section candidate
no_agent (15.425 s) : 15425000, 15425000
. : milestone, 15425000,
appsec (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
iast (18.735 s) : 18735000, 18735000
. : milestone, 18735000,
iast_GLOBAL (17.936 s) : 17936000, 17936000
. : milestone, 17936000,
profiling (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
tracing (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Run
aggregate_test_countsjob on Merge Queue only instead of per-PRMotivation
Reduce per-PR CI time while keeping test count protection
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.