fix(tests): swallow AssertionError in setup_and_teardown teardown#584
Draft
michael-richey wants to merge 1 commit into
Draft
fix(tests): swallow AssertionError in setup_and_teardown teardown#584michael-richey wants to merge 1 commit into
michael-richey wants to merge 1 commit into
Conversation
assert in test_resource_cleanup causes pytest to report ERROR at teardown rather than a test failure when a prerequisite import step returns non-zero. Wrap the call in try/except so the fixture exits cleanly; the safety invariant is preserved because the failing assert already prevents the sync --cleanup=force from running, so live users/roles are never deleted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_resource_cleanupusesassert 0 == ret.exit_codeon the users/roles import steps. When called fromsetup_and_teardown's teardown phase (not as an actual test), a failing assert propagates uncaught and pytest reports it asERROR at teardownrather than a normal test failure.test_resource_cleanupcall intry/except AssertionErrorso the fixture exits cleanly and logs a warning instead.sync --cleanup=forceruns, so live users/roles are never accidentally deleted when the prerequisite import fails.Test plan
TestNotebooksResources.test_resource_importno longer showsERROR at teardownBaseResourcesTestClass)🤖 Generated with Claude Code