Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 8f0ed26 | Docs | Datadog PR Page | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30d6fe8b20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Root cache directory | ||
| Mount(type="volume", path="/var/cache/dd", source=self.get_volume_name("cache")), |
There was a problem hiding this comment.
IIUC, we're now using a single volume for all caches rather than one volume per cache type - can you explain why this is ?
There was a problem hiding this comment.
This is for better discoverability and cache management. Rather than separate volumes, there is one hierarchical tree with permissions that are applied recursively. It makes everything easier!
| return [] | ||
|
|
||
| return ["-v", f"{global_shared_dir / 'shell' / 'starship.toml'}:/root/.shared/shell/starship.toml"] | ||
| return ["-v", f"{global_shared_dir / 'shell' / 'starship.toml'}:/.shared/shell/starship.toml"] |
There was a problem hiding this comment.
Why not /home/dd/.shared/... ?
There was a problem hiding this comment.
This is used by our tooling at startup and ideally shouldn't be seen by users.
2 participants
This makes the Linux developer environments only support versions of the image after DataDog/datadog-agent-buildimages#1089.
Release strategy
Rather than introduce temporary backward compatibility hacks in both the image and our tooling we will release both in lockstep.
CHANGELOG.mdand merge that