fix: move providers inside ErrorBoundary to prevent crash loop

[frano-m]

Summary

Fixes the infinite retry loop when a filter query parameter contains an invalid value (#4776).

Root Cause

ExploreStateProvider, DataDictionaryStateProvider, and FileManifestStateProvider were positioned above the ErrorBoundary in the component tree. When ExploreStateProvider's reducer crashed (e.g. JSON.parse on a malformed filter URL param, or accessing .length on a wrong-shape filter object), the error bypassed the ErrorBoundary entirely and bubbled up to Next.js's built-in error handling. Next.js attempted to recover by re-rendering the page, which hit the same crash again — creating an infinite loop.

Fix

Move the three providers inside the ErrorBoundary:

Before:                          After:
ExploreStateProvider             Main
  DataDictionaryStateProvider      ErrorBoundary ← catches all errors below
    Main                             ExploreStateProvider
      ErrorBoundary                    DataDictionaryStateProvider
        FileManifestStateProvider        FileManifestStateProvider
          Component                        Component

Now any error from the providers' reducers, hooks, or child components is caught by the ErrorBoundary and renders the Error fallback page. The Header and Footer remain outside the boundary so the user can still navigate away from the error page.

Why this works

The Error fallback component does not consume ExploreState, DataDictionaryState, or FileManifestState — it only needs the error object, a reset callback, and the root path (from app config). There is no reason these providers need to be above the boundary.

Closes #4776

Test plan

Tested all three invalid filter param cases:

• Malformed/truncated JSON (?filter=%5B%7B%22categoryKey...) → shows error page
• Wrong shape (?filter=[{"facetName":"bogus","terms":["invalid"]}]) → shows error page
• Correct shape, invalid values (?filter=[{"categoryKey":"bogus","value":["invalid"]}]) → shows API 400 error page
• Valid filters still work normally
• Unit tests pass (101/101)
• AnVIL Catalog e2e tests pass (48/48, 9 skipped)
• AnVIL CMG e2e tests pass (125/126 — 1 pre-existing flaky filter tag failure)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Moves key state providers under the app-level ErrorBoundary so reducer/hook crashes (e.g., invalid filter URL params) are caught by the fallback UI instead of triggering Next.js re-render recovery loops.

Changes:

• Reordered component tree in _app.tsx to place ExploreStateProvider, DataDictionaryStateProvider, and FileManifestStateProvider inside the ErrorBoundary.
• Kept Header/Footer outside the boundary so navigation remains available on the error fallback page.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.