fix(TypeHandler): use the custom type handler when packing a list parameter#2068
fix(TypeHandler): use the custom type handler when packing a list parameter#2068tlecomte wants to merge 1 commit intoDapperLib:mainfrom
Conversation
…ameter Fixes DapperLib#2067 The code for `SqlMapper.PackListParameters` was not using the custom type handler. This caused an error like `No mapping exists from object type xxxxx to a known managed provider native type.` when passing a collection parameter to a query, when the type of the collection items is not natively supported by the SQL client, and when a custom `TypeHandler` is registered for it. Here this is fixed by using the same logic that is already in `DynamicParameters.AddParameter`. A unit test is added to cover the scenario.
|
Dear @mgravell, please see here a PR to fix an issue with list parameters and custom type handlers. Thank you very much for considering this! |
|
I was just about to post an issue regarding this very thing when I saw this pull request. Hope this gets merged soon. I have a custom type handler for |
|
A year later, and we have the exact same issue @SimonAfek is describing. |
|
@mgravell Just a gentle bump on this one when you have the bandwidth! If the author is unavailable to make any requested changes, please let me know. I'm happy to take over to get this merged. |
Fixes #2067
The code for
SqlMapper.PackListParameterswas not using the custom type handler. This caused an error likeNo mapping exists from object type xxxxx to a known managed provider native type.when passing a collection parameter to a query, when the type of the collection items is not natively supported by the SQL client, and when a customTypeHandleris registered for it.Here this is fixed by using the same logic that is already in
DynamicParameters.AddParameter.A unit test is added to cover the scenario.