[Port dspace-8_x] Replace old SHERPA/ROMEO references by Open Policy Finder#5803
Conversation
(cherry picked from commit cf13c14)
lgeggleston
changed the title
lgeggleston
added
high priority
integration: Open Policy Finder
lgeggleston
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (10.x, 9.x, 8.x)
lgeggleston
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace Maintenance (10.x, 9.x, 8.x)
|
@bram-maegerman : Thanks for this backport PR. However, please note that it appears to be failing compilation (see test failures). |
(cherry picked from commit 5ce7c48)
bram-maegerman
force-pushed
the
backport-5493-to-dspace-8_x
branch
from
e0ae83b to
72bc55b
Compare
|
@tdonohue Thanks for notifying me! I've fixed the test issue and all checks have passed now. |
|
@bram-maegerman , can you integrate the changes to the i18n resources that I’ve made in the PR #5833? Thanks! |
|
@saschaszott Done! |
|
Hi @bram-maegerman, I tested this backport with the related backend. I noticed that a label is missing. Could you add it, please? Thanks! |
|
@Micheleboychuk , is this missing label related to the SHERPA/ROMEO - OPF changes? |
yes, only on this PR, the dspace-9_x is ok |
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @bram-maegerman . Code looks good & it's been tested by @Micheleboychuk .
Regarding the missing item.preview.creativeworkseries.issn i18n key, that's not a fault of this PR. So, I'm not going to hold up this PR waiting on a fix to that missing i18n key. (The reason this key seems to only exist in 9.x is because it was added in #4017, which was newly added in 9.0. So, that key will need to be backported to 8.x if it's needed there)
github-project-automation
Bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (10.x, 9.x, 8.x)
5 participants
References
Backport of #5493 & #5800.
Requires REST backport PR: #12315