Skip to content

[DSpace-CRIS] Implement detailed error handling for custom url conflicts#5475

Open
FrancescoMolinaro wants to merge 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-470
Open

[DSpace-CRIS] Implement detailed error handling for custom url conflicts#5475
FrancescoMolinaro wants to merge 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-470

Conversation

@FrancescoMolinaro
Copy link
Copy Markdown
Contributor

@FrancescoMolinaro FrancescoMolinaro commented Apr 13, 2026

References

Fixes: #5078
Relates to: #4814

Description

Implemented error handling on item page for custom url conflict.
Added direct link to administrative edit for item correction.

image

Instructions for Reviewers

Implemented a new component shown on the item page when a custom URL lookup returns a 500 error, which indicates that multiple items share the same dspace.customurl value.
Uses SearchService.search() with a dspace.customurl filter to find all items with the conflicting value, then renders a direct edit link (/edit-items/:FULL) for each result so administrators can immediately navigate to and fix the affected items.
Placed inside the item page template when itemRD.statusCode === 500 and the resolved route param is not a UUID (i.e. it was a custom URL lookup).

Step to reproduce:

  • Define an identical custom url on multiple items
  • Navigate to the item page of one of the items

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug high priority DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. blocker This ticket or PR will block whatever release milestone is associated with it. labels Apr 13, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker This ticket or PR will block whatever release milestone is associated with it. bug DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. high priority

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

[DSpace-CRIS] Duplicate "Custom URLs" can be created from the "Administer -> Metadata" screen because of lack of validation

2 participants