Skip to content

Add singular/plural support for QA notification messages#5344

Open
oscar-escire wants to merge 1 commit intoDSpace:mainfrom
oscar-escire:Issue/4202
Open

Add singular/plural support for QA notification messages#5344
oscar-escire wants to merge 1 commit intoDSpace:mainfrom
oscar-escire:Issue/4202

Conversation

@oscar-escire
Copy link
Copy Markdown
Contributor

References

Description

This PR fixes the incorrect pluralization in QA notification messages. Previously, when exactly 1 suggestion was present, the message incorrectly displayed "There are 1 pending suggestions" instead of the grammatically correct singular form.

Instructions for Reviewers

  1. Log in as an administrator
  2. Navigate to My DSpace page
  3. Verify QA notification messages:
    • Sources with 1 suggestion should display: "There is 1 pending suggestion related to your account"
    • Sources with 2+ suggestions should display: "There are X pending suggestions related to your account"

List of changes in this PR:

  • Added separate translation keys with .one and .other suffixes for singular/plural forms in en.json5 and de.json5
  • Updated qa-event-notification.component.html to conditionally select the correct translation key based on totalEvents count
  • Updated my-dspace-qa-events-notifications.component.html with the same pluralization logic

Note: Testing requires QA events configured in the backend.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 1, 2026
@lgeggleston
Copy link
Copy Markdown

@MMilosz since you assigned yourself for review on the original PR for this, would you still be open to being a reviewer on this? Thanks!

@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug i18n / l10n Internationalisation and localisation, related to message catalogs port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Incorrect plural in translation for single pending suggestion

2 participants