Open
Conversation
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
lgeggleston
added
i18n / l10n
saschaszott
previously approved these changes
Mar 12, 2026
Contributor
saschaszott
left a comment
saschaszott
left a comment
There was a problem hiding this comment.
Thank you, @Kasinhou . This all seems reasonable to me. This PR is ready to be merged.
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
saschaszott
reviewed
Mar 12, 2026
|
|
||
| "submission.workflow.tasks.claimed.reject.submit": "Reject", | ||
|
|
||
| "submission.workflow.tasks.claimed.reject_help": "If you have reviewed the item and found it is <strong>not</strong> suitable for inclusion in the collection, select \"Reject\". You will then be asked to enter a message indicating why the item is unsuitable, and whether the submitter should change something and resubmit.", |
Contributor
There was a problem hiding this comment.
@Kasinhou , could you please replace the two blanks after the first sentence by a single blank.
|
|
||
| "error.validation.coarnotify.invalidfilter": "Invalid filter, try to select another service or none.", | ||
|
|
||
| "request-status-alert-box.accepted": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been taken in charge.", |
Contributor
There was a problem hiding this comment.
@Kasinhou , could you please remove the blanks atfer > and before </a>.
|
|
||
| "request-status-alert-box.accepted": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been taken in charge.", | ||
|
|
||
| "request-status-alert-box.rejected": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been rejected.", |
Contributor
There was a problem hiding this comment.
@Kasinhou , could you please remove the blanks atfer > and before </a>.
|
|
||
| "request-status-alert-box.rejected": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been rejected.", | ||
|
|
||
| "request-status-alert-box.tentative_rejected": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been tentatively rejected. Revisions are required", |
Contributor
There was a problem hiding this comment.
@Kasinhou , could you please remove the blanks atfer > and before </a>.
|
|
||
| "request-status-alert-box.tentative_rejected": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been tentatively rejected. Revisions are required", | ||
|
|
||
| "request-status-alert-box.requested": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> is pending.", |
Contributor
There was a problem hiding this comment.
@Kasinhou , could you please remove the blanks atfer > and before </a>.
saschaszott
dismissed
their stale review
found several translations with spacing issues
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix spacing issues in en.json5 translation file.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.