Skip to content

Fix - Change the breadcrumbs to list on platform mobile,#3075

Closed
VictorHugoDuranS wants to merge 1 commit intoDSpace:dspace-7_xfrom
VictorHugoDuranS:dspace-7_2680
Closed

Fix - Change the breadcrumbs to list on platform mobile,#3075
VictorHugoDuranS wants to merge 1 commit intoDSpace:dspace-7_xfrom
VictorHugoDuranS:dspace-7_2680

Conversation

@VictorHugoDuranS
Copy link
Contributor

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:

References

Description

Hide breadcrumbs in list for platform mobile

Instructions for Reviewers

I aded a validation for platform mobile, it hide the breadcrumbs in a dropdown for accessibility according to recommendation, in a platform desktop it work normality

image image

For see the change, i recommended change size of the navigator web or watch it in a mobile device

List of changes in this PR:

  • First, I add the services HostWindowService to the component BreadcrumbsComponent
  • Second, I added the modules "NgbDropdownModule" and "NgbTooltipModule" to the root.module.ts for use it
  • Third, I changed the main container for validate if the component is in a platform mobile, if it is in a platform mobile show de dropdown
  • Fourth, I divided the breadcrumb for show the dropdown in one container and the active breadcrumb in another container
  • Fifth, I added a separation with tag "" for the dropdown and active breadcrumb

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • [] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added improvement 1 APPROVAL pull request only requires a single approval to merge labels May 24, 2024
@tdonohue tdonohue requested a review from artlowel August 8, 2024 14:53
vins01-4science pushed a commit to 4Science/dspace-angular that referenced this pull request Apr 11, 2025
Task/dspace cris 2023 02 x/DSC-2279

Approved-by: Giuseppe Digilio
@kanasznagyzoltan
Copy link
Contributor

Before checking out the PR branch:

image

After checking out PR branch:

image

Seems to be working as intended. Clicking the elipsis brings up the breadcrumbs

image

@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release May 19, 2025
@tdonohue tdonohue linked an issue Mar 10, 2026 that may be closed by this pull request
@lgeggleston
Copy link

Closing this in favor of #5277 since the new PR seems to be based off of this, and I assume a decision was made at eScire to open the new one. @VictorHugoDuranS and @guillermo-escire if you decide something different should happen, let me know.

@github-project-automation github-project-automation bot moved this from 👀 Under Review to ✅ Done in DSpace 10.0 Release Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge improvement

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Breadcrumbs collapse in mobile mode

4 participants