-
Notifications
You must be signed in to change notification settings - Fork 54
Add stats service #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+523
−9
Merged
Add stats service #207
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c067597
initial code for stats service
ehinman e00bb69
modularize stats function, fix paging
ehinman 00d0cf9
fix input types
ehinman 65dff7f
I don't think this is necessary here, as non-200's are treated as errors
ehinman c17a07f
get rid of warnings.warn
ehinman f7ee053
fix non geopandas flattening
ehinman 1865aa3
break up function into two, add in further unnesting
ehinman 98e3e86
Apply suggestions from code review
ehinman 4c46ead
merge with main, add in percentiles for max, min, median, add example
ehinman 709450a
fix issue with column name not always being present given the inputs,…
ehinman 7127924
add unit tests, correct issue with init file
ehinman a21a464
fix testing to take into account geopandas?
ehinman 8f2bc0a
clean up documentation descriptions a little bit
ehinman 193205e
change function names, add more to documentation
ehinman 8ff1ae5
alphabetical order
ehinman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be helpful to also mention that setting
expand_percentiles = Falseand requesting'percentiles'and one of['median', 'minimum', 'maximum', 'arithmetic_mean']will return avalueandvaluescolumn, whereasexpand_percentiles = Truewill consolidate these columns into a singlevaluecolumn. Requesting just'percentiles'andexpand_percentiles = Falsewill return just avaluescolumn. There's probably a simpler way to describe this than how I've said.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I have added some information about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I wasn't saying you should change the function names to match dR, just that they were different.
The
read_stats_porandread_stats_daterangenaming convention was to make it easier for tab-completion (i.e., someone typesread_statsthen tab to see the two options appear).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good change. The same sort of thing can be applied in python. It's nice to be consistent. Now to deal with this sudden ubuntu failure, ugh.