Missing enums, classes, methods and funcs#292
Open
ANTINICKNAMES wants to merge 4 commits intoDK22Pac:masterfrom
Open
Missing enums, classes, methods and funcs#292ANTINICKNAMES wants to merge 4 commits intoDK22Pac:masterfrom
ANTINICKNAMES wants to merge 4 commits intoDK22Pac:masterfrom
Conversation
Contributor
ANTINICKNAMES
commented
Mar 15, 2026
ANTINICKNAMES
commented
- Added missing Animation Enums
- Added Initialise method in CAEPedSpeechAudioEntity class.
- Added Load/Save funcs for CAERadioTrackManager, CGameLogic, CGarages, CPathFind, CPlayerInfo.
- Added CTagManager, CStuntJumpManager, CShopping, CPedType and SurfaceInfos_c classes. (untested)
- Added missing methods and classes for CPostEffects. (untested)
- Added data members for CTaskSimpleHoldEntity.
- Added missing CLines class.
- Fixed ScriptParams array in CTheScripts
- Added new Events: renderMirror, renderScene, renderEffects, drawFontsEvent
1. Added missing Animation Enums 2. Added Initialise method in CAEPedSpeechAudioEntity class. 3. Added Load/Save funcs for CAERadioTrackManager, CGameLogic, CGarages, CPathFind, CPlayerInfo. 4. Added CTagManager, CStuntJumpManager, CShopping, CPedType and SurfaceInfos_c classes. 5. Added missing methods and classes for CPostEffects. 6. Added data members for CTaskSimpleHoldEntity.
Contributor
Author
|
I know it's a (bit) messy... Let me know if something wrong. |
MiranDMC
reviewed
Mar 15, 2026
| #pragma once | ||
|
|
||
| // original name. prev name eAnimID | ||
| enum AnimationIds : int32_t { |
Contributor
There was a problem hiding this comment.
Why plural form? It was "AnimationId" in reversed project
MiranDMC
reviewed
Mar 15, 2026
| }; | ||
|
|
||
| /* | ||
| // [GROUP] i = 0 | GroupName : default | Group ID: 0 | Total Animations: 191 |
Contributor
There was a problem hiding this comment.
Why there is ton of commented out crap?
MiranDMC
reviewed
Mar 15, 2026
| 0x53E83C, H_CALL, | ||
| 0x53EBA2, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> drawAfterFadeEvent; | ||
|
|
||
| static inline CdeclEvent <AddressList<0x53EBB1, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> drawFontsEvent; |
Contributor
There was a problem hiding this comment.
Can you add same events for III and VC?
MiranDMC
reviewed
Mar 15, 2026
| #include "meta/meta.CTheScripts.h" | ||
|
|
||
| SUPPORTED_10US extern int* ScriptParams; // 32 | ||
| SUPPORTED_10US extern int (&ScriptParams)[10]; // 32 |
Contributor
There was a problem hiding this comment.
Comment says 32 and you are making it 10
MiranDMC
reviewed
Mar 15, 2026
| struct imf { | ||
| float screenZ; | ||
| float recipCameraZ; | ||
| RwRaster* RasterDrawBuffer; |
Contributor
There was a problem hiding this comment.
not aligned as everything else?
MiranDMC
reviewed
Mar 15, 2026
| float m_fHeadingChangeRate; | ||
| int field_564; | ||
| int field_568; | ||
| CEntity* m_standingOnEntity; |
MiranDMC
suggested changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.