fix: Add missing comparator for VulnerabilityAnalysis#812
Merged
jkowalleck merged 2 commits intoCycloneDX:mainfrom May 10, 2025
Merged
fix: Add missing comparator for VulnerabilityAnalysis#812jkowalleck merged 2 commits intoCycloneDX:mainfrom
jkowalleck merged 2 commits intoCycloneDX:mainfrom
Conversation
added 2 commits
May 9, 2025 12:28
Signed-off-by: Riku Häkli <hakli.riku@gmail.com>
Signed-off-by: Riku Häkli <hakli.riku@gmail.com>
jkowalleck
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to generate a CycloneDX BOM that has two vulnerabilities that only differ in their analysis, you get
This PR adds the
__lt__method for the VulnerabilityAnalysis model to fix sorting and also includes a test case to verify the fix.