Skip to content

Allow specification of Subnet CIDR for Runners #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hexa2k9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow specification of Subnet CIDR for Runners #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gcp/net-vpc.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module "vpc-github-runners" {
description = "VPC for GitHub Actions Runners (Terraform-managed)"
subnets = [
{
ip_cidr_range = "100.64.0.0/16" # https://en.wikipedia.org/wiki/Carrier-grade_NAT
ip_cidr_range = coalesce(var.github_runners_internal_cidr, "100.64.0.0/16") # https://en.wikipedia.org/wiki/Carrier-grade_NAT
name = "subnet-github-runners-${local.region_shortnames[var.region]}"
region = var.region
description = "Subnet for GitHub Actions Runners in ${var.region} (Terraform-managed)"
Expand Down
7 changes: 7 additions & 0 deletions gcp/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ variable "zone" {
}
}

variable "github_runners_internal_cidr" {
description = "The Internal IP Range used for the GitHub Actions Runners"
type = string
default = null
nullable = true
}

# Minimum number of Cloud Run instances for the GitHub Actions Runners manager application
# Unfortunately, the Cloud Run cold start time is slow and often exceeds 30 seconds.
# GitHub expects a response to webhook requests in under 10 seconds!
Expand Down