Skip to content

Add test for collector package AddToPod function#4430

Merged
dsessler7 merged 1 commit intoCrunchyData:mainfrom
dsessler7:otel-addtopod-test
Feb 18, 2026
Merged

Add test for collector package AddToPod function#4430
dsessler7 merged 1 commit intoCrunchyData:mainfrom
dsessler7:otel-addtopod-test

Conversation

@dsessler7
Copy link
Collaborator

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

No testing of collector.AddToPod function.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Go test for collector.AddToPod function which gives us more collector package test coverage and ensures the Instrumentation configuration fields environmentVariables and files get tested.

Other Information:

Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question.

@dsessler7 dsessler7 requested a review from tjmoore4 February 17, 2026 22:45
@dsessler7 dsessler7 merged commit 31574a2 into CrunchyData:main Feb 18, 2026
20 of 21 checks passed
@dsessler7 dsessler7 deleted the otel-addtopod-test branch February 18, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments