dependabot and PR template #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Linting failure is not caused by this commit. See #71 |
shaeespring
force-pushed
the
shaeespring/dependabot
branch
from
7038949 to
70d6ec2
Compare
Contributor
Author
|
Now solves #71 |
| application=applicant_info, | ||
| pdf_url='/application/content/'+app_id, | ||
| info=info, | ||
| fields=fields) |
There was a problem hiding this comment.
There was a problem hiding this comment.
given, i definitely could just test this to see if it works but that sounds like a lot of thought
Contributor
Author
There was a problem hiding this comment.
The linting failure was for "unused variable" here. I couldn't even find a definition of what it was.
Contributor
Author
There was a problem hiding this comment.
Oh I lied, it was for variable undefined. vote.html needs it. I misunderstood the problem. I thought it didn't need fields, hence why it was undefined, but in fact "fields" was deleted from this function somewhere along the way. Very good catch. Thank you
shaeespring
force-pushed
the
shaeespring/dependabot
branch
from
c3e8173 to
8c63b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.