Fix no_invalid_shell_accounts_unlocked for unlocked user in last line of /etc/passwd#14751
Conversation
… of /etc/passwd When the last line in /etc/passwd is an unlocked user with a valid shell, the shell path was parsed as '/path/to/shell\n' instead of just '/path/to/shell' and the comparison to valid shells list failed. Fixes: ComplianceAsCode#13657
guyy-claroty
requested review from
Mab879,
jan-cerny,
matusmarhefka and
vojtapolasek
as code owners
|
Hi @guyy-claroty. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
I have run the TSs locally on a RHEL 9 VM and they passed
2 participants
When the last line in /etc/passwd is an unlocked user with a valid shell, the shell path was parsed as '/path/to/shell\n' instead of just '/path/to/shell' and the comparison to valid shells list failed.
Fixes: #13657
Description:
Rationale:
Rationale here. Replace this text. Don't use the italics format!
Fixes # Issue number here (e.g. Updating sysctl XCCDF naming #26) or remove this line if no issue exists.
Review Hints:
Review hints here. Replace this text. Don't use the italics format!
Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.
Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.