Conversation
|
Would have to update |
| hidden=True, | ||
| ) | ||
| @tracking.track_command("node") | ||
| def registry_install( |
There was a problem hiding this comment.
registry_install -> we would need to update the commands inside the registry_web repository https://github.com/Comfy-Org/registry-web/blob/23948cfe4faa73f640a48139479a718a2d561ccd/components/nodes/NodeDetails.tsx#L209.
This should be replaced with a new command. node install <node_id>@<version>
| ) | ||
| @tracking.track_command("node") | ||
| def show_versions( | ||
| node_name: str, |
There was a problem hiding this comment.
node_name or node_id? Should we use node_id here?
| # To check more robustly, verify up to the `.git` path. | ||
| manager_path = os.path.join( | ||
| self.workspace_path, "custom_nodes", "ComfyUI-Manager" | ||
| cached_manager_path = self.config_manager.get( |
There was a problem hiding this comment.
Previously, we knew the absolute path of the comfyUI manager. With the new changes, the comfyUI manager directory name would change depending on which version you've installed (e.g., nightly vs. specific version). We need to figure out the directory of the ComfyUI Manager.
Let's add comments explaining what this logic is.
There was a problem hiding this comment.
This logic may not work if we are caching the repository name for multiple workspace.
| else: | ||
| manager_repo_dir = os.path.join(repo_dir, "custom_nodes", "ComfyUI-Manager") | ||
| manager_repo_dir = os.path.join( | ||
| repo_dir, "custom_nodes", "comfyui-manager@nightly" |
There was a problem hiding this comment.
We may need to change this. Depending on the version of comfyUI manager, the repo directory would change.
telamonian
force-pushed
the
main
branch
3 times, most recently
from
a582b27 to
0348aa4
Compare
|
suppressed by #363 |
4 participants
requires
ComfyUI-Manager/feat/cnr