Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 36 36
Lines 1470 1470
Branches 477 477
=======================================
Hits 1435 1435
Misses 35 35
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md#rules
I don't know why, but it looks like the pages for each rule is behind auth, so I couldn't check them.
I've basically enabled almost every rules, disabled rules that were previously disabled, disabled the
awsrules, and disabled new rules that seemed inconvenient.I haven't checked other rules that have not been an issue in this repo, so there are probably some more rules that we may want to disable.