Fix & Refactor Download Speed Limiter System#859
Open
Conversation
+ As per now, due to behavioral changes from this refactor, the Burst Download Mode can now be enabled while Download Speed Limiter is enabled. Even though, this won't affect any performance as the speed download is now limited by the Speed Limiter.
neon-nyan
added
Enhancement
Cryotechnic
requested changes
Feb 22, 2026
Member
There was a problem hiding this comment.
CollapseLauncher/StaticLib/StaticLib.7z.0-23 have 0 bytes size?
Also, see comments, build must pass before merging:
[D:\a\Collapse\Collapse\CollapseLauncher\CollapseLauncher.csproj]
EXEC : fatal error C1900: Il mismatch between 'P1' version '20250730' and 'P2' version '20240319' [D:\a\Collapse\Collapse\CollapseLauncher\CollapseLauncher.csproj]
LINK : fatal error LNK1257: code generation failed [D:\a\Collapse\Collapse\CollapseLauncher\CollapseLauncher.csproj]
D:\a\Collapse\Collapse\.nuget\packages\microsoft.dotnet.ilcompiler\10.0.3\build\Microsoft.NETCore.Native.targets(396,5): error MSB3073: The command ""C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\Hostx64\x64\link.exe" @"obj\x64\Debug\net10.0-windows10.0.26100.0\win-x64\native\link.rsp"" exited with code 1257. [D:\a\Collapse\Collapse\CollapseLauncher\CollapseLauncher.csproj]
Comment on lines
+14
to
+17
| /* | ||
| return LauncherConfig.DownloadSpeedLimit > 0 ? | ||
| Math.Min(LauncherConfig.DownloadSpeedLimit, speed) : | ||
| speed; |
| } | ||
|
|
||
| // Check if user has permission | ||
| bool isUserHasPermission = ConverterTool.IsUserHasPermission(gameFolder); |
Member
There was a problem hiding this comment.
Possible null reference argument for parameter 'input' in 'bool ConverterTool.IsUserHasPermission(string input)'.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+170
to
+178
| protected nint SpeedLimiterServiceContext { get; } = SpeedLimiterService.CreateServiceContext(); | ||
|
|
||
| public bool IsSophonInUpdateMode { get; protected set; } | ||
| protected bool IsAllowExtractCorruptZip { get; set; } | ||
|
|
||
| ~ProgressBase() | ||
| { | ||
| SpeedLimiterService.FreeServiceContext(SpeedLimiterServiceContext); | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Goal
This PR brings up major changes on Download Speed Limiter System which brings a lot of advantages. We are switching from decentralized design of the feature into a newly unified, centralized service for Data Processing Throttling. We are utilizing our new lightweight, native library called Hi3Helper.Throttle.
There are few changes included within this Pull Request, including:
PR Status :
Templates
Changelog Prefixes