Skip to content

fix: prevent SSRF via JSON import handlers #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexia-Soare wants to merge 1 commit into
base: development
Choose a base branch
from
+115 −1
Open

fix: prevent SSRF via JSON import handlers #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions classes/Visualizer/Module/Chart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ public function setJsonSchedule() {
public function getJsonRoots() {
check_ajax_referer( Visualizer_Plugin::ACTION_JSON_GET_ROOTS . Visualizer_Plugin::VERSION, 'security' );

if ( ! current_user_can( 'edit_posts' ) ) {
wp_send_json_error( array( 'msg' => esc_html__( 'You do not have permission to perform this action.', 'visualizer' ) ) );
}

$params = wp_parse_args( $_POST['params'] );

$source = new Visualizer_Source_Json( $params );
Expand All @@ -192,6 +196,10 @@ public function getJsonRoots() {
public function getJsonData() {
check_ajax_referer( Visualizer_Plugin::ACTION_JSON_GET_DATA . Visualizer_Plugin::VERSION, 'security' );

if ( ! current_user_can( 'edit_posts' ) ) {
wp_send_json_error( array( 'msg' => esc_html__( 'You do not have permission to perform this action.', 'visualizer' ) ) );
}

$params = wp_parse_args( $_POST['params'] );

$chart_id = $params['chart'];
Expand Down
2 changes: 1 addition & 1 deletion classes/Visualizer/Source/Json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ function ( $headers ) {
}

do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'Connecting to %s with args = %s ', $url, print_r( $args, true ) ), 'debug', __FILE__, __LINE__ );
return wp_remote_request( $url, $args );
return wp_safe_remote_request( $url, $args );
}

/**
Expand Down
106 changes: 106 additions & 0 deletions tests/test-ajax.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,112 @@ public function test_sql_save_chart_admin() {
$this->assertFalse( $response->success );
}

/**
* JSON get-roots must be denied for users without `edit_posts` (issue #591 access-control fix).
*/
public function test_json_get_roots_denied_for_subscriber() {
wp_set_current_user( $this->subscriber_user_id );
$this->_setRole( 'subscriber' );

$_GET['security'] = wp_create_nonce( Visualizer_Plugin::ACTION_JSON_GET_ROOTS . Visualizer_Plugin::VERSION );
$_POST['params'] = array(
'url' => 'http://127.0.0.1:9999/latest/meta-data/',
'method' => 'GET',
);

try {
$this->_handleAjax( Visualizer_Plugin::ACTION_JSON_GET_ROOTS );
} catch ( WPAjaxDieContinueException $e ) {
// We expected this, do nothing.
}

$response = json_decode( $this->_last_response );
$this->assertIsObject( $response );
$this->assertFalse( $response->success );
$this->assertEquals( 'You do not have permission to perform this action.', $response->data->msg );
}

/**
* JSON get-data must be denied for users without `edit_posts` (issue #591 access-control fix).
*/
public function test_json_get_data_denied_for_subscriber() {
wp_set_current_user( $this->subscriber_user_id );
$this->_setRole( 'subscriber' );

$_GET['security'] = wp_create_nonce( Visualizer_Plugin::ACTION_JSON_GET_DATA . Visualizer_Plugin::VERSION );
$_POST['params'] = array(
'url' => 'http://127.0.0.1:9999/',
'method' => 'GET',
'chart' => 1,
);

try {
$this->_handleAjax( Visualizer_Plugin::ACTION_JSON_GET_DATA );
} catch ( WPAjaxDieContinueException $e ) {
// We expected this, do nothing.
}

$response = json_decode( $this->_last_response );
$this->assertIsObject( $response );
$this->assertFalse( $response->success );
$this->assertEquals( 'You do not have permission to perform this action.', $response->data->msg );
}

/**
* A permitted user (contributor) is not blocked by the guard, and the JSON source fetches through the
* SSRF-safe transport (`reject_unsafe_urls`), matching the CSV path (issue #591 SSRF fix).
*/
public function test_json_get_roots_allowed_for_contributor_uses_safe_transport() {
wp_set_current_user( $this->contibutor_user_id );
$this->_setRole( 'contributor' );

$captured = array();
add_filter(
'pre_http_request',
function ( $pre, $args, $url ) use ( &$captured ) {
$captured[] = array(
'url' => $url,
'reject' => ! empty( $args['reject_unsafe_urls'] ),
);
return array(
'headers' => array(),
'body' => wp_json_encode( array( 'results' => array( array( 'id' => 1 ) ) ) ),
'response' => array(
'code' => 200,
'message' => 'OK',
),
'cookies' => array(),
'filename' => null,
);
},
10,
3
);

$_GET['security'] = wp_create_nonce( Visualizer_Plugin::ACTION_JSON_GET_ROOTS . Visualizer_Plugin::VERSION );
$_POST['params'] = array(
'url' => 'http://127.0.0.1:9999/latest/meta-data/',
'method' => 'GET',
);

try {
$this->_handleAjax( Visualizer_Plugin::ACTION_JSON_GET_ROOTS );
} catch ( WPAjaxDieContinueException $e ) {
// We expected this, do nothing.
}

$response = json_decode( $this->_last_response );
$this->assertIsObject( $response );
// The capability guard must NOT block a user who has edit_posts.
$msg = isset( $response->data->msg ) ? $response->data->msg : '';
$this->assertNotEquals( 'You do not have permission to perform this action.', $msg );
// Every outbound request for the JSON source must use the SSRF-safe transport.
$this->assertNotEmpty( $captured, 'The JSON source did not attempt any fetch.' );
foreach ( $captured as $req ) {
$this->assertTrue( $req['reject'], 'JSON fetch must use wp_safe_remote_* (reject_unsafe_urls => true).' );
}
}

/**
* Utility method to mock pro version.
*/
Expand Down
Loading