Conversation
TavoNiievez
force-pushed
the
new_asserts
branch
from
e1200e3 to
1e515ac
Compare
|
Hi @ThomasLandauer @xEdelweiss , Can you take a look at the PR and give me your opinion on the new methods, please? |
| * $I->seeDoctrineDatabaseIsUp('custom'); | ||
| * ``` | ||
| * | ||
| * @param non-empty-string $connectionName The name of the Doctrine connection to check. |
There was a problem hiding this comment.
Do you mean the name of the entity manager (in case you have multiple)?
| * $I->seeDoctrineProxyDirIsWritable('custom'); | ||
| * ``` | ||
| */ | ||
| public function seeDoctrineProxyDirIsWritable(string $entityManagerName = 'default'): void |
There was a problem hiding this comment.
Are you aware that Doctrine is moving away from their own proxy system, in favor of the new native PHP lazy objects? So (as far as I understand it), the proxy dir soon won't be needed anymore.
| * | ||
| * ```php | ||
| * <?php | ||
| * $I->assertSymfonyVersion('>=', '6.4'); |
There was a problem hiding this comment.
Does this also work with one and three digit versions?
| * $I->seeAppEnvAndDebugMatchKernel(); | ||
| * ``` | ||
| */ | ||
| public function seeAppEnvAndDebugMatchKernel(): void |
There was a problem hiding this comment.
- How is it possible that they don't mach?
- Are you only looking at real environment variables or also at resolved
.envvariables?
| /** | ||
| * Helper to get the project's root directory. | ||
| */ | ||
| protected function getProjectDir(): string |
There was a problem hiding this comment.
I usually do it like this:
$kernel = $I->grabService('kernel');
$kernel->getContainer()->getParameter('foobar');Is this just a shortcut? I'm asking cause if there's a shortcut for this one parameter, I always ask myself: What about all the others?
| } | ||
|
|
||
| /** | ||
| * Asserts that a security firewall is configured and active. |
There was a problem hiding this comment.
"Active" in the sense that it was actually used for the current request? Or just generally up and running?
|
Well, these are many... :-)
|
|
Hi @TavoNiievez |
3 participants
No description provided.