London | 26-SDC-July | Raihan Sharif | Sprint 1 | individual-shell-tools#566
Open
RaihanSharif wants to merge 38 commits into
Open
London | 26-SDC-July | Raihan Sharif | Sprint 1 | individual-shell-tools#566RaihanSharif wants to merge 38 commits into
RaihanSharif wants to merge 38 commits into
Conversation
RaihanSharif
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
SlideGauge
reviewed
Jul 11, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Good job, I got just a couple of comments from my side, fix them please.
|
|
||
| # TODO: Write a command which lists the files in the child-directory directory, one per line, sorted so that the most recently modified file is first. | ||
| # The output should be a list of names in this order, one per line: helper-3.txt, helper-1.txt, helper-2.txt. | ||
| ls -1t |
There was a problem hiding this comment.
Right now the script targets the current dir. Is that what we're asked for?
|
|
||
| # TODO: Write a command to output every line in dialogue.txt that does not contain the word "Hello" (regardless of case). | ||
| # The output should contain 10 lines. | ||
| grep -vi 'hello' ./dialogue.txt | grep . No newline at end of file |
There was a problem hiding this comment.
The task is to output 10 lines. Does this script do this?
Author
There was a problem hiding this comment.
No it does not.
Fixed by removing the pipe into grep . which was intended to filter out the blank line.
|
|
||
| # -E is extended regex, needed for + (one or more) quantifier | ||
| # [[:space:]] is POSIX compliant | ||
| sed -E s'/[0-9]+[[:space:]]//g' ./input.txt |
There was a problem hiding this comment.
Note, that the output should be " Alisha", not "Alisha". Space has been lost
Author
There was a problem hiding this comment.
Fixed now. I should have read the requirement more carefully.
| # space after number is part of the pattern but not the group | ||
| # 2 is everything else | ||
| # then print out group 2, a space, and then group 1 | ||
| sed -E 's/^([0-9]+) (.*)/\2 \1/' input.txt |
There was a problem hiding this comment.
Clean capture-group swap with a clear comment explaining each group. Well done on one of the trickier ones.
SlideGauge
added
Reviewed
RaihanSharif
added
Needs Review
This comment has been minimized.
This comment has been minimized.
RaihanSharif
added
Needs Review
This comment has been minimized.
This comment has been minimized.
RaihanSharif
force-pushed
the
individual-shell-tools
branch
from
0a60e4d to
31e3fac
Compare
RaihanSharif
added
Needs Review
|
Results of test: |
github-actions
Bot
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all exercises for individual shell tools