Automate testing of initial sprints in tools module#472
Automate testing of initial sprints in tools module#472LonMcGregor wants to merge 18 commits intoCodeYourFuture:mainfrom
Conversation
LonMcGregor
commented
Apr 7, 2026
LonMcGregor
commented
- Expected output now in expected folder
- Github action which runs on push/label
- Script that can be run to test locally before push
* number-systems qanda formatting * numbers-expected * num sys checker * tests for numsys * fix diffing * test bin task action * finalise readme for merge --------- Co-authored-by: l <l>
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Generally looks really good, and very useful!
One thing I really like about the metadata validator one that this doesn't do is collapse old comments... I just put together CodeYourFuture/trainee-tracker#68 so that we can just run a standalone binary to close existing comments - if we add <!--CYFTT tag: sdc-test-results--> somewhere in the comment we leave, we can use that binary to minimise past comments. WDYT?
| - reopened | ||
| - synchronize | ||
| paths: | ||
| - '**.sh' |
There was a problem hiding this comment.
Does this not mean that it won't trigger for the number systems README.md file change?
| pull-requests: write | ||
|
|
||
| steps: | ||
| - name: checkout base branch |
There was a problem hiding this comment.
Shall we add a filtering step that cancels this run if there isn't a "Needs Review" label?
And maybe also add a dependency on the 'Validate PR Metadata' workflow so that we don't run if it's failing?
| pass=$(($pass+1)) | ||
| else | ||
| if [[ "$exercise" == *"stretch"* ]]; then | ||
| # echo "Stretch task $directory$exercise failing, you can ignore this if you did not attempt. If you didnt, please have the volunteer check this." |
There was a problem hiding this comment.
Shall we check if the file was modified, and ignore if it wasn't?
| # echo "Stretch task $directory$exercise failing, you can ignore this if you did not attempt. If you didnt, please have the volunteer check this." | ||
| total=$(($total-1)) | ||
| else | ||
| echo "Failed $directory$exercise, please either attempt again or have the volunteer check this." >> ../../testoutput.txt |
There was a problem hiding this comment.
"have the volunteer check this" - is this an instruction to the trainee ("Please find a volunteer") or to a volunteer ("This PR is in the Needs Review list for a reason") or something else?
| fi | ||
| fi | ||
| cat testoutput.txt | ||
| elif [[ "$1" == "number-systems" ]]; then |
There was a problem hiding this comment.
I'd be tempted to separate this out into two files? One automatically checked, one manually checked?
2 participants
