London| 26-ITP-May | Martin Mwaka | Sprint 3 | Stretch#1464
Open
Temceo wants to merge 7 commits into
Open
Conversation
Temceo
added
🏝️ Priority Stretch
LonMcGregor
reviewed
Jul 13, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these stretch tasks. I have some comments
| // Pay particular attention to the following: | ||
|
|
||
| // a) How the index variable updates during the call to find | ||
| // [MM] - The index variable increments by one each time the letter (str[index]) at the current index does not match the target letter (char) |
There was a problem hiding this comment.
Tip: You don't need to include your name in comments as git keeps track of who made what changes.
| // Must have more than one type of number | ||
| const hasMultipleDistinctDigits = new Set(cardStr.split("")).size > 1; | ||
|
|
||
| return has16Digits && |
There was a problem hiding this comment.
This looks correct, but can you read the task specification again? See what the return type of the function is meant to be.
|
|
||
| const checks = { | ||
| minLength: password.length > 4, | ||
| hasUpperCase: /[A-Z]/.test(password), |
There was a problem hiding this comment.
good use of regular expressions here
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have completed sprint 3 stretch tasks in folder 4-stretch