Skip to content

West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 1 | Module-Structuring-and-Testing-Data#1442

Open
burhan-mustafa wants to merge 18 commits into
CodeYourFuture:mainfrom
burhan-mustafa:coursework/sprint-1
Open

West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 1 | Module-Structuring-and-Testing-Data#1442
burhan-mustafa wants to merge 18 commits into
CodeYourFuture:mainfrom
burhan-mustafa:coursework/sprint-1

Conversation

@burhan-mustafa

@burhan-mustafa burhan-mustafa commented Jul 2, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all tasks in repos solved all tasks in sprint 1

@github-actions

This comment has been minimized.

5 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@burhan-mustafa burhan-mustafa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected Module-Structuring-And-Testing-Data The name of the module. Core This is a core task and should be completed by all trainees 📅 Sprint 1 Assigned during Sprint 1 of this module labels Jul 2, 2026
Comment thread Sprint-1/1-key-exercises/4-random.js Outdated
Comment thread Sprint-1/2-mandatory-errors/1.js Outdated
// trying to create an age variable and then reassign the value by 1

const age = 33;
var age = 33;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use let instead of var.

Note: Feel free to use AI to find out why use of 'var' is not recommended.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do not use var because its scope rules and redeclaration rules can cause bugs. Thats why let and const are usually used instead. This change has been made : )

Comment thread Sprint-1/2-mandatory-errors/3.js Outdated
Comment thread Sprint-1/2-mandatory-errors/4.js Outdated
Comment on lines -23 to +22
// e) What do you think the variable result represents? Can you think of a better name for this variable?

// Answer: The expressions uses the modulo function to work out the remainder value which in this case works out the remaining seconds of the total movie length

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part (e) has a second question. Could you also answer that?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The file where I left this comment was 2-time-format.js. I just noticed you updated 1-percentage-change.js instead.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies this has been rectified now

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2026
@burhan-mustafa burhan-mustafa added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also address this comment: #1442 (comment) ?

Comment on lines -23 to +22
// e) What do you think the variable result represents? Can you think of a better name for this variable?

// Answer: The expressions uses the modulo function to work out the remainder value which in this case works out the remaining seconds of the total movie length

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted question (e) in your file. The original question is;
// e) What do you think the variable result represents? Can you think of a better name for this variable?

The variable which question (e) refers to is the one named result on line 9:

const result = `${totalHours}:${remainingMinutes}:${remainingSeconds}`;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed :)

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@burhan-mustafa burhan-mustafa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 12, 2026
@cjyuan

cjyuan commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Core This is a core task and should be completed by all trainees Module-Structuring-And-Testing-Data The name of the module. 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants