Skip to content

London | 26-ITP-May | Dagim Daniel | Sprint 1 | 1-key-exercise -count #1375

Open
Dagim-Daniel wants to merge 5 commits into
CodeYourFuture:mainfrom
Dagim-Daniel:coursework/sprint-1
Open

London | 26-ITP-May | Dagim Daniel | Sprint 1 | 1-key-exercise -count #1375
Dagim-Daniel wants to merge 5 commits into
CodeYourFuture:mainfrom
Dagim-Daniel:coursework/sprint-1

Conversation

@Dagim-Daniel

Copy link
Copy Markdown

… created a branch coursework/sprint-1.

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

i just created a branch coursework/sprint-1 and also answered 1-key exercise through multiple line comment.

Questions

we can answer some question through comment right?

@Dagim-Daniel Dagim-Daniel added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 21, 2026
@Dagim-Daniel Dagim-Daniel added the 🏕 Priority Mandatory This work is expected label Jun 26, 2026
Comment thread Sprint-1/1-key-exercises/4-random.js
Comment thread Sprint-1/2-mandatory-errors/3.js Outdated
Comment on lines 1 to 2
const cardNumber = "4533787178994213";
const last4Digits = cardNumber.slice(-4);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose you were not allowed to modify the statement const cardNumber = 4533787178994213;
(that is, keep the variable's value unchanged).
How would you modify the code (through type conversion) to still being able to use .slice(-4) to extract the last 4 digits from the given number.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will use .toString() for conversion.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi Cjyuan do i need to send new PR for me to make this PR complete, i thought we solve it here. if i need to push new PR do tell me please.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to my latest comment: #1375 (comment)


// b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
//syntaxError: missing ) after argument list, -
//the error is occurring because of a missing "," in the replaceAll() method. in line 5.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could more precisely describe where the comma is missing as
"... because a comma is missing between "," and "" in the function call" or
"... because a comma is missing between the ___________s."

What is the programming term that belongs in the blank?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 27, 2026
@cjyuan

cjyuan commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

we can answer some question through comment right?

If the questions are placed in the comments, yes.

@cjyuan

cjyuan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
  1. Without the "Needs review" label, I cannot be sure if your PR is ready to be rereviewed.

  2. You marked this comment:
    London | 26-ITP-May | Dagim Daniel | Sprint 1 | 1-key-exercise -count  #1375 (comment)
    as "resolved" without any response in the comment. So I expected you to make the corresponding change in the code. However, I don't see any new changes on this PR branch.

    If you have made any changes to your code (on this branch), you would need to push them to GitHub for the changes to appear on this PR branch.

@Dagim-Daniel Dagim-Daniel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026
@cjyuan

cjyuan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

All good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 🏕 Priority Mandatory This work is expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants