Skip to content

Manchester | May-2026-ITP | Monsur Abdulrahman | Sprint 1 | Coursework Exercises#1334

Open
Monsur0001 wants to merge 16 commits into
CodeYourFuture:mainfrom
Monsur0001:coursework/sprint-1
Open

Manchester | May-2026-ITP | Monsur Abdulrahman | Sprint 1 | Coursework Exercises#1334
Monsur0001 wants to merge 16 commits into
CodeYourFuture:mainfrom
Monsur0001:coursework/sprint-1

Conversation

@Monsur0001

@Monsur0001 Monsur0001 commented Jun 13, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist

I have done all the required tasks in Sprint 1

Monsur0001 added 15 commits June 13, 2026 14:43
@Monsur0001
Refactor initials variable assignment to directly concatenate first c…
8095f51 
…haracters
@Monsur0001
Implement dir and ext variable assignments in file path extraction
3fd21e6
@Monsur0001
Breaking the expression and explaining what they mean
688f25b
@Monsur0001
Improve documentation clarity by adding inline comments to expression…
63c562a 
…s in random number generation
@Monsur0001
Add comments to prevent execution of instructional lines in 0.js
cab937e
@Monsur0001
Change age variable declaration from const to let for reassignment
7186dfa
@Monsur0001
Fix console log placement to correctly print city of birth
27bff53
@Monsur0001
Fix last4Digits assignment to correctly use slice on string represent…
2f2a720 
…ation of cardNumber
@Monsur0001
Fix variable naming to follow camelCase convention for clock time con…
1cc8d56 
…stants
@Monsur0001
Add detailed comments to explain function calls, error identification…
89ca1ed 
…, variable reassignment, and expression purpose in 1-percentage-change.js
@Monsur0001
Enhance comments for clarity on variable declarations, function calls…
f402c6f 
…, and expressions in 2-time-format.js
@Monsur0001
Add detailed comments to explain each step of the pence to pounds con…
ed8a5e7 
…version process in 3-to-pounds.js
@Monsur0001
Refactor comments for clarity and consistency in 3-to-pounds.js
9d06c8b
@Monsur0001
Add explanations for prompt function effects in chrome.md
d3193ff
@Monsur0001
Enhance explanations in objects.md for console output and syntax usage
d60c972
@Monsur0001 Monsur0001 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 13, 2026
LonMcGregor
LonMcGregor reviewed Jun 19, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, some changes needed, see my comments.

Good work doing the stretch tasks!

Comment thread Sprint-1/1-key-exercises/4-random.js
Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 19, 2026
@Monsur0001

Monsur0001 commented Jul 10, 2026

Copy link
Copy Markdown
Author

I addressed the issue raised by the reviewer

@Monsur0001 Monsur0001 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 10, 2026
@LonMcGregor

LonMcGregor commented Jul 13, 2026

Copy link
Copy Markdown

Apologies for the delay in your review. You've completed the task now, good work

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Monsur0001 @LonMcGregor