London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 3 | practice tdd#1265
Open
djebsoft wants to merge 17 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 3 | practice tdd#1265djebsoft wants to merge 17 commits intoCodeYourFuture:mainfrom
djebsoft wants to merge 17 commits intoCodeYourFuture:mainfrom
Conversation
djebsoft
added
the
Needs Review
cjyuan
reviewed
Mar 15, 2026
cjyuan
added
Reviewed
mshayriyesaricicek
added
Needs Review
cjyuan
added
Reviewed
4 tasks
djebsoft
added
the
Needs Review
cjyuan
reviewed
Mar 16, 2026
| return "1st"; | ||
| let remainder1 = num % 10; | ||
| let remainder2 = num % 100; | ||
| if (remainder1 === 1 && remainder2 !== 11) { |
Contributor
There was a problem hiding this comment.
Best practice is to give variables descriptive (self-explanatory) names. Can you rename these two variables to make the code more readable.
| let remainder1 = num % 10; | ||
| let remainder2 = num % 100; | ||
| if (remainder1 === 1 && remainder2 !== 11) { | ||
| // we also can use if (num[-1]===1 && num.slice(-2)!==11) |
Contributor
There was a problem hiding this comment.
Note: This expression (in the comment) is comparing a string to a number.
| // When the number does not end with 1, 2, or 3 | ||
| // Then the function should return a string by appending "th" to the number. | ||
|
|
||
| test("should append 'th' for all other numbers", () => { |
Contributor
There was a problem hiding this comment.
This test description is what Jest output in the test report. It's better to replace "all other numbers" by the detailed condition described on line 50.
cjyuan
removed
the
Needs Review
djebsoft
added
the
Needs Review
cjyuan
reviewed
Mar 16, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
| let lastDigit = num % 10; | ||
| let lastTwoDigits = num % 100; | ||
| if (lastDigit === 1 && lastTwoDigits !== 11) { | ||
| // we also can use if (num[-1]==="1" && num.slice(-2)!=="11") |
Contributor
There was a problem hiding this comment.
Note: num[-1] is not the syntax to extract the last character in JavaScript. It will be evaluated to undefined.
Use .at(-1) or .slice(-1) instead.
Author
There was a problem hiding this comment.
I changed it to .slice() instead of index to extract the last character
thank you
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
buit up my program test then wrote the code that will make them pass.
Questions