Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 3 | Dead Code#1256
Open
Richiealx wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 3 | Dead Code#1256Richiealx wants to merge 1 commit intoCodeYourFuture:mainfrom
Richiealx wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Richiealx
added
the
Needs Review
SlideGauge
reviewed
Mar 15, 2026
| // The sayHello function should continue to work for any reasonable input it's given. | ||
|
|
||
| let testName = "Jerry"; | ||
| let testName = "Aman"; |
There was a problem hiding this comment.
Nice catch we use "Aman" instead of "Jerry"
| const greeting = "hello"; | ||
|
|
||
| function sayHello(greeting, name) { | ||
| const greetingStr = greeting + ", " + name + "!"; |
There was a problem hiding this comment.
Correct, the greetingStr is not needed either
SlideGauge
added
Complete
|
Complete, nice job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the Sprint 3 dead code task.
Changes made
Sprint-3/3-dead-code/exercise-1.jsSprint-3/3-dead-code/exercise-2.jsTesting
I tested the changes by running:
node Sprint-3/3-dead-code/exercise-1.jsnode Sprint-3/3-dead-code/exercise-2.jsBoth scripts produced the expected output.
Questions
No questions at this time.