Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | coursework/sprint-3-practice-tdd#1249
Open
marthak1 wants to merge 10 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | coursework/sprint-3-practice-tdd#1249marthak1 wants to merge 10 commits intoCodeYourFuture:mainfrom
marthak1 wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
marthak1
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
marthak1
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
marthak1
changed the title
marthak1
added
the
Needs Review
cjyuan
reviewed
Mar 13, 2026
Comment on lines
+35
to
+39
| test("should append 'th' for numbers ending with 4", () => { | ||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(20)).toEqual("20th"); | ||
| expect(getOrdinalNumber(100)).toEqual("100th"); | ||
| }); |
Contributor
There was a problem hiding this comment.
Does this category only cover numbers ending with 4?
Author
There was a problem hiding this comment.
Thanks for the feedback. The category covers 4,5,6,7,8,9 and 0. But only these test cases will be covered. Amended the test decription to reflect this
Comment on lines
+23
to
+35
| test("should repeat the string count times", () => { | ||
| const str = "hello"; | ||
| const count = 1; | ||
| const repeatedStr = repeatStr(str, count); | ||
| expect(repeatedStr).toEqual("hello"); | ||
| }); | ||
| // Case: Handle count of 0: | ||
| // Given a target string `str` and a `count` equal to 0, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return an empty string. | ||
|
|
||
| test("should repeat the string count times", () => { | ||
| const str = "hello"; | ||
| const count = 0; |
Contributor
There was a problem hiding this comment.
Three of the tests in this file have the same description. When a test fails, it will take longer time to find out which of them fails.
Can you make these descriptions distinct and more informative?
| // Given a target string `str` and a negative integer `count`, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should throw an error, as negative counts are not valid. | ||
| test(`Should throw an error`, () => { |
Contributor
There was a problem hiding this comment.
Can you also describe the condition of which the function is expected to throw an error?
For example, in the form Should throw an error when ...
cjyuan
added
Reviewed
Removed console.log statement from character counting loop.
marthak1
added
the
Needs Review
cjyuan
reviewed
Mar 14, 2026
| }); | ||
|
|
||
| // Case 2: Numbers ending in 2 → add nd → (2nd, 22nd, 42nd) | ||
| test("should append 'nd' for numbers ending with 2", () => { |
Contributor
There was a problem hiding this comment.
It is probably better to clarify this category does not include numbers ending with 12.
cjyuan
removed
the
Needs Review
marthak1
added
the
Needs Review
cjyuan
reviewed
Mar 14, 2026
| expect(getOrdinalNumber(142)).toEqual("142nd"); | ||
| }); | ||
| // Case 3: Numbers ending in 3 → add rd → (3rd, 23rd, 53rd) | ||
| test("should append '3rd' for numbers ending with 3", () => { |
Contributor
There was a problem hiding this comment.
Could also update this description to exclude numbers like 13, 113.
cjyuan
added
Complete
marthak1
added
the
Needs Review
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement practice TDD exercises