Manchester | 26-ITP-Jan | Liban Jama | Sprint 3 | Implement and rewrite tests by libanj0161 · Pull Request #1197 · CodeYourFuture/Module-Structuring-and-Testing-Data

libanj0161 · 2026-03-06T19:06:03Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed Implement and rewrite tests.

Questions

N/A.

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

cjyuan · 2026-03-16T13:55:12Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test("should return correct result when numerator or denominator is negative", () => {
+  expect(isProperFraction(-5, 9)).toEqual(true);
+  expect(isProperFraction(-2, 0)).toEqual(false);
+});


Could consider combine this into case 2. Otherwise the description does not quite describe the tests in this category.

You could also consider use the notations |...| in the descriptions of improper fractions.

Are the changes what you was expecting?

cjyuan · 2026-03-18T11:40:18Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

-// Case 7: Invalid angles
-test(`should return "Invalid angles" when (angle >360)`, () => {
+// Case 6: Invalid angles
+test(`should return "Invalid angles" when (angle is =<0 &&>=360)`, () => {


<= would probably look more natural than =< to programmers.

i've made that change, thank you.

cjyuan · 2026-03-18T11:43:31Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  else if (Number(rank) >= 2 && Number(rank) <= 10) {
+    return Number(rank);


In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "0002".

Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠"); getCardValue("2.1♠"); getCardValue("0002♠");

Done, thank you.

cjyuan · 2026-03-18T11:51:34Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test("should return correct result when numerator or denominator is negative", () => {
+  expect(isProperFraction(-5, 9)).toEqual(true);
+  expect(isProperFraction(-2, 0)).toEqual(false);
+});


cjyuan · 2026-03-18T22:57:33Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

Have you tested your implementation with this script?

yes and it passed

Unless you have different files on your computer, I don't see how your function can pass this test. Both the function implementation and the tests have bugs.

ok ill fix those bugs, thanks

Altered function to pass failing test.

cjyuan

A string without a suit character is to be considered an invalid card. I guess you misunderstood the spec. A fix should be pretty straight forward, so I will mark this as "Complete" first.

cjyuan · 2026-03-19T14:46:19Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

+// Case 3: Number Cards (2-10)
+test(`Should return numerical value when given an number card`, () => {
+  expect(getCardValue("5")).toEqual(5);
+});


Supposedly a valid card is a string in this format: "5♠".

"5" (without the suit character), would be considered an invalid card.

Thanks, ive changed that.

Function implementation is correct.

This test category is supposed for valid number cards.

libanj0161 added 3 commits March 6, 2026 18:54

Completed 1-get-angle-type

1924ef4

Completed 2-is-proper-fraction

a73fa1a

Completed 3-get-card-value

3d438c6

libanj0161 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 6, 2026

cjyuan reviewed Mar 13, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 13, 2026

Updated after feedback

f6f394c

libanj0161 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 16, 2026

libanj0161 requested a review from cjyuan March 16, 2026 11:06

cjyuan reviewed Mar 16, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 16, 2026

Updated as per PR comments

254abc7

libanj0161 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 18, 2026

libanj0161 requested a review from cjyuan March 18, 2026 11:16

cjyuan reviewed Mar 18, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 18, 2026

Updated after PR comments

1a4482e

libanj0161 requested a review from cjyuan March 18, 2026 14:47

libanj0161 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 18, 2026

cjyuan reviewed Mar 18, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 18, 2026

fixed error

aabad30

cjyuan reviewed Mar 19, 2026

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 19, 2026

Further updates

c555833

libanj0161 requested a review from cjyuan March 19, 2026 16:25

libanj0161 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

libanj0161 mentioned this pull request Mar 19, 2026

26-ITP-Jan | Structuring and testing data | LIBAN_JAMA libanj0161/My-Coursework-Planner#8

Open

		else if (Number(rank) >= 2 && Number(rank) <= 10) {
		return Number(rank);

Uh oh!

Conversation

libanj0161 commented Mar 6, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan Mar 18, 2026 •

edited

Loading

cjyuan Mar 18, 2026 •

edited

Loading

cjyuan Mar 19, 2026 •

edited

Loading

cjyuan Mar 19, 2026 •

edited

Loading