Skip to content

London | 26-ITP-Jan | Mohsen Zamani | Sprint 3 | Alarm Clock#955

Open
mohsenzamanist wants to merge 2 commits intoCodeYourFuture:mainfrom
mohsenzamanist:feature/sprint-3-alarmclock
Open

London | 26-ITP-Jan | Mohsen Zamani | Sprint 3 | Alarm Clock#955
mohsenzamanist wants to merge 2 commits intoCodeYourFuture:mainfrom
mohsenzamanist:feature/sprint-3-alarmclock

Conversation

@mohsenzamanist
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Complete Sprint 3 Alarm Clock.

Questions

@mohsenzamanist mohsenzamanist added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<h1 id="timeRemaining">Time Remaining: <span>00:00</span></h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look into how to prevent the alarmclock from taking negative input (-1 or lower)?

@codeschris codeschris added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026
@mohsenzamanist mohsenzamanist added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 16, 2026
Copy link

@codeschris codeschris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well implemented!

@codeschris codeschris added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants