Skip to content

[SSF-232] Edit & Delete Donation Items Frontend #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiang-h-y wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[SSF-232] Edit & Delete Donation Items Frontend #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9c6fb76
fixing lint errors
jiang-h-y Jun 24, 2026
2206eaa
requested changes
jiang-h-y Jun 25, 2026
f0d7ea5
fix unresponsive ui bug after clicking cancel on delete donation modal
jiang-h-y Jun 25, 2026
fbe00ba
resolve merge conflict
jiang-h-y Jun 25, 2026
a29799a
allow admins to edit/delete + remove hasAllocations check
jiang-h-y Jun 27, 2026
ca17883
Merge branch 'main' into hj/SSF-232-edit-delete-donations
jiang-h-y Jun 27, 2026
85cfb64
Merge branch 'main' into hj/SSF-232-edit-delete-donations
jiang-h-y Jun 28, 2026
fa5e014
requested changes
jiang-h-y Jun 29, 2026
52f3d40
requested changes
jiang-h-y Jun 29, 2026
fc83487
Merge branch 'main' into hj/SSF-232-edit-delete-donations
jiang-h-y Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions apps/backend/src/donations/donations.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ export class DonationsController {
}

@Roles(Role.FOODMANUFACTURER)
Comment thread
jiang-h-y marked this conversation as resolved.
@CheckOwnership({
idParam: 'foodManufacturerId',
idSource: 'body',
resolver: resolveCreateDonationAuthorizedUserIds,
})
@Post()
@ApiBody({
description: 'Details for creating a donation',
Expand Down Expand Up @@ -116,7 +111,6 @@ export class DonationsController {
},
},
})
@Roles(Role.FOODMANUFACTURER)
async createDonation(
@Req() req: AuthenticatedRequest,
@Body() body: CreateDonationDto,
Expand All @@ -138,7 +132,7 @@ export class DonationsController {
await this.donationService.updateDonationItemDetails(donationId, body);
}

@Roles(Role.FOODMANUFACTURER)
@Roles(Role.FOODMANUFACTURER, Role.ADMIN)
@CheckOwnership({
idParam: 'donationId',
resolver: resolveDonationAuthorizedUserIds,
Expand All @@ -152,7 +146,7 @@ export class DonationsController {
await this.donationService.editDonationItems(donationId, body);
}

@Roles(Role.FOODMANUFACTURER)
@Roles(Role.FOODMANUFACTURER, Role.ADMIN)
@CheckOwnership({
idParam: 'donationId',
resolver: resolveDonationAuthorizedUserIds,
Expand Down
14 changes: 12 additions & 2 deletions apps/frontend/src/api/apiClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ import { NavigateFunction } from 'react-router-dom';
import { ROUTES } from '../routes';
import {
User,
Order,
FoodRequest,
FoodManufacturer,
DonationItem,
Donation,
Allocation,
CreateFoodRequestBody,
Pantry,
PantryApplicationDto,
Expand Down Expand Up @@ -45,6 +43,7 @@ import {
PendingApplication,
UpdateFoodRequestBody,
DonationReminderDto,
ReplaceDonationItemDto,
} from 'types/types';

const defaultBaseUrl =
Expand Down Expand Up @@ -453,6 +452,17 @@ export class ApiClient {
);
}

public async editDonationItems(
donationId: number,
items: ReplaceDonationItemDto[],
): Promise<void> {
await this.axiosInstance.patch(`/api/donations/${donationId}/item`, items);
}

public async deleteDonation(donationId: number): Promise<void> {
await this.axiosInstance.delete(`/api/donations/${donationId}`);
}

public async updateFoodManufacturerApplicationData(
manufacturerId: number,
data: UpdateFoodManufacturerApplicationDto,
Expand Down
Loading
Loading