Conversation
There was a problem hiding this comment.
Seeing a really weird thing on this branch (confirmed main is fine) where whenever I click any of the links in any of the tables on any of the pages (to open a modal / etc.) and then close it, I can no longer click anything on the page without refreshing. guessing this must've somehow been caused by the chakra update (sorry)... could you look into this?
|
tbh i tried everything and the only way seems to be either setting |
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
It would be nice if you could click anywhere in the date received input box and it would open up the date picker, rather than turning into a very confusing numeric input.
very annoying with chakra, I trust there's no better way to fix that. chakra update very ssf 🙃
| resetForm(); | ||
| onSuccess(); | ||
| onClose(); | ||
| } catch (err) { |
There was a problem hiding this comment.
Can we set an alert message rather than removing this?
| onChange={(e) => setDateReceived(e.target.value)} | ||
| value={dateReceived} | ||
| /> | ||
| <DatePicker.Root |
There was a problem hiding this comment.
Not quite sure which component you would change, but can we make the arrows actually match the Figma: https://www.figma.com/design/brc5luMhizIFp893XIutYe/SP26---SSF-Designs?node-id=1891-28804&m=dev
or confirm with priya that these are good?
|
|
||
| const handleSubmit = async () => { | ||
| try { | ||
| if (new Date(dateReceived) < new Date(orderCreatedAt)) { |
There was a problem hiding this comment.
dont think we need this anymore. with the calendar, its not possible choose an earlier date with the min attribute.
| const today = new Date(); | ||
| today.setHours(0, 0, 0, 0); | ||
|
|
||
| if (new Date(dateReceived) > today) { |
|
|
||
| // DatePicker component props | ||
| export interface DatePickerRootProps extends ComponentPropsLenientChildren { | ||
| min?: any; |
There was a problem hiding this comment.
Could we change these to CalendarDate types instead of any?
| min={parseDate(minDate)} | ||
| max={parseDate(today)} | ||
| value={dateReceived ? [parseDate(dateReceived)] : []} | ||
| onValueChange={({ value }) => { |
There was a problem hiding this comment.
Can this be neutral 700 font weight 600, like it is in the figma?
3 participants
ℹ️ Issue
Closes SSF-196
📝 Description
✔️ Verification
frontend verification
