[SSF-182] Admin, Volunteer, & Pantry Dashboard Backend#158
Open
[SSF-182] Admin, Volunteer, & Pantry Dashboard Backend#158
Conversation
Yurika-Kan
requested changes
Apr 25, 2026
Collaborator
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
first round review~~
looking super good! thanks amy :)
| return this.volunteersService.findOne(userId); | ||
| } | ||
|
|
||
| @Roles(Role.VOLUNTEER, Role.ADMIN) |
Collaborator
There was a problem hiding this comment.
can we check that the id is an existing user (volunteer/admin) w a checkownership block on this route?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-182
📝 Description
GET /api/users/admin/recent-pending-applicationsto return 4 most recent pantry/FM appsgetRecentPendingApplicationsin users service and controller w/ corresponding testsGET /api/volunteers/:id/my-recent-ordersto return 2 most recent ordersgetRecentOrdersin volunteers service and controller w/ corresponding tests/api/requests/:pantryId/allto/api/pantries/:pantryId/requestsand renamed service function tofindAllForPantry(pantryId)in requests serviceGET /api/pantries/:pantryId/orders✔️ Verification
tests pass and verified on postman