Skip to content

[SSF 190] - Navbar#156

Merged
dburkhart07 merged 17 commits intomainfrom
ddb/SSF-190-navigation-sidebar
Apr 25, 2026
Merged

[SSF 190] - Navbar#156
dburkhart07 merged 17 commits intomainfrom
ddb/SSF-190-navigation-sidebar

Conversation

@dburkhart07
Copy link
Copy Markdown

ℹ️ Issue

Closes #190

📝 Description

  • Removed deprecated pages
  • Implemented Navbar for all 4 components and matched Figma design
  • Updated login page to just be a white line with the SSF icon at the top (copying the Figma desgn)

✔️ Verification

Made sure all pages rendered properly
image
image

🏕️ (Optional) Future Work / Notes

N/A

@Yurika-Kan Yurika-Kan self-requested a review April 13, 2026 22:35
Copy link
Copy Markdown
Member

@amywng amywng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

i don't love that the line hits the background on hover - can we ask priya about this?

also, the ticket says to make dummy pages for every route so that the navbar includes everything that's in the figma, can you do that?

Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/app.tsx
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Copy link
Copy Markdown
Collaborator

@Yurika-Kan Yurika-Kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very exciting ticket. we are naving. some bugs but we ball

Comment thread apps/frontend/src/containers/root.tsx
Comment thread apps/frontend/src/containers/loginPage.tsx
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/containers/orders.tsx Outdated
Copy link
Copy Markdown
Member

@amywng amywng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think you've made placeholder pages for the dashboards, which is in the ticket. can you also add your recently merged admin donation stats page?

Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/containers/foodManufacturerApplicationDetails.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx
Comment thread apps/frontend/src/components/Navbar.tsx
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/containers/loginPage.tsx Outdated
@dburkhart07 dburkhart07 requested a review from amywng April 21, 2026 06:12
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/components/Navbar.tsx
@dburkhart07 dburkhart07 requested a review from amywng April 22, 2026 22:23
Copy link
Copy Markdown
Member

@amywng amywng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slack msg but lgtm

Copy link
Copy Markdown
Collaborator

@Yurika-Kan Yurika-Kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny fixes + fuzzy white line in bg image on Mac~

approving with tiny fixes to do!

Comment thread apps/frontend/src/containers/homepage.tsx Outdated
Comment thread apps/frontend/src/containers/root.tsx
@dburkhart07 dburkhart07 merged commit 5fdbf27 into main Apr 25, 2026
4 checks passed
@dburkhart07 dburkhart07 deleted the ddb/SSF-190-navigation-sidebar branch April 25, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants