[SSF 170] - New Endpoints for FM Required Actions by dburkhart07 · Pull Request #139 · Code-4-Community/ssf

dburkhart07 · 2026-03-27T04:16:50Z

ℹ️ Issue

Closes #170

📝 Description

Added new DTO for confirming donation item details
Created new donation endpoint to update the donation item details
Update the order tracking to require both tracking link and shipping cost
Added logic for both endpoints to fulfill the donation when appropriate (see ticket)
Wrote/updated tests for each

✔️ Verification

Tested endpoints
Ensured all tests passed

apps/backend/src/donations/donations.service.ts

apps/backend/src/orders/order.service.ts

apps/backend/src/donations/donations.service.spec.ts

apps/backend/src/donations/donations.service.ts

.claude/settings.local.json

apps/backend/src/orders/order.service.ts

apps/backend/src/utils/donation.utils.spec.ts

apps/backend/src/donationItems/dtos/confirm-donation-item-details.dto.ts

apps/backend/src/donations/donations.service.ts

apps/backend/src/utils/donation.utils.ts

apps/backend/src/donations/donations.service.ts

apps/backend/src/orders/order.service.ts

apps/backend/src/donations/donations.service.ts

apps/backend/src/utils/donation.utils.ts

apps/backend/src/donationItems/donationItems.service.ts

apps/backend/src/donationItems/donationItems.service.spec.ts

apps/backend/src/donations/donations.service.spec.ts

apps/backend/src/orders/order.service.spec.ts

sam-schu

last few small suggestions, thanks! manual testing looked good

apps/backend/src/orders/order.service.spec.ts

apps/backend/src/donations/donations.service.spec.ts

dburkhart07 added 6 commits March 27, 2026 00:16

Initial implementation

2a08425

Initial implementation

370f376

updated tests

861d601

merged main

fbf9d7d

Fixed modules

5ad33d6

updated logs

69e0480

dburkhart07 marked this pull request as ready for review March 30, 2026 04:10

dburkhart07 changed the title ~~Initial implementation~~ [SSF 170] - New Endpoints for FM Required Actions Mar 30, 2026

amywng requested changes Mar 30, 2026

View reviewed changes

sam-schu self-requested a review March 30, 2026 20:05

Addressed comments

c924c6d

dburkhart07 requested a review from amywng March 31, 2026 23:34

amywng requested changes Apr 1, 2026

View reviewed changes

comments

326e9c6

dburkhart07 requested a review from amywng April 1, 2026 04:34

amywng requested changes Apr 1, 2026

View reviewed changes

.claude/settings.local.json Outdated Show resolved Hide resolved

apps/backend/src/orders/order.service.ts Show resolved Hide resolved

apps/backend/src/utils/donation.utils.spec.ts Outdated Show resolved Hide resolved

comments

4b04a5b

dburkhart07 requested a review from amywng April 2, 2026 00:33

sam-schu requested changes Apr 3, 2026

View reviewed changes

dburkhart07 added 2 commits April 4, 2026 17:14

Merged main

a82bae4

sam changes

2548071

dburkhart07 requested a review from sam-schu April 4, 2026 22:07

dburkhart07 added 2 commits April 10, 2026 22:18

amy hates me sm

e1b9a66

final commit pls

5cb530d

amywng approved these changes Apr 11, 2026

View reviewed changes

sam-schu requested changes Apr 11, 2026

View reviewed changes

comments

1db2c70

dburkhart07 requested a review from sam-schu April 12, 2026 17:01

sam-schu requested changes Apr 12, 2026

View reviewed changes

apps/backend/src/donationItems/donationItems.service.ts Outdated Show resolved Hide resolved

comments

b52b676

dburkhart07 requested a review from sam-schu April 12, 2026 20:00

sam-schu requested changes Apr 12, 2026

View reviewed changes

comments

b91d79b

dburkhart07 requested a review from sam-schu April 13, 2026 01:31

dburkhart07 added 3 commits April 12, 2026 22:19

fixed tests

e9e29db

final commit fr this time

3aa5173

finally fixed tests!!

39458a8

sam-schu approved these changes Apr 13, 2026

View reviewed changes

apps/backend/src/orders/order.service.spec.ts Outdated Show resolved Hide resolved

apps/backend/src/donations/donations.service.spec.ts Show resolved Hide resolved

merged main and updated tests

12af052

dburkhart07 merged commit 6af4559 into main Apr 13, 2026
4 checks passed

dburkhart07 deleted the ddb/SSF-170-endpoints-for-fm-required-donations branch April 13, 2026 05:50

Conversation

dburkhart07 commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ℹ️ Issue

📝 Description

✔️ Verification

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sam-schu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dburkhart07 commented Mar 27, 2026 •

edited

Loading