232 add approve/decline for expenses#259
Open
Rayna-Yu wants to merge 3 commits into
Open
Conversation
Contributor
Terraform Plan 📖
|
nourshoreibah
approved these changes
Jul 1, 2026
nourshoreibah
left a comment
nourshoreibah
left a comment
Collaborator
There was a problem hiding this comment.
One question but wont block
Comment on lines
1
to
+5
| export const EXPENDITURE_STATUSES = ['approved', 'pending', 'denied', 'needs_more_info'] as const; | ||
| export type ExpenditureStatus = typeof EXPENDITURE_STATUSES[number]; | ||
|
|
||
| export const APPROVAL_STATUSES = ['approved', 'denied'] as const; | ||
| export type ApprovalStatus = typeof APPROVAL_STATUSES[number]; |
Collaborator
There was a problem hiding this comment.
Are these duplicate types?
Collaborator
There was a problem hiding this comment.
Like EXPENDITURE_STATUSES vs APPROVAL_STATUSES? sorry should have clarified in ticket but I think the above types are all valid (approved pending denied needs_more_info).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#232
Closes #232
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
Briefly list the changes made to the code:
✔️ Verification
Added tests
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!