edit cost backend now tells the frontend that a cost with this name a…#403
Open
prooflesben wants to merge 2 commits intomainfrom
Open
edit cost backend now tells the frontend that a cost with this name a…#403prooflesben wants to merge 2 commits intomainfrom
prooflesben wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes your mom
📝 Description
Edit cost backend errored correctly when trying to set the name of a cost to an already existing cost but didn't give the frontend the error. The backend now sends a 409 error.
✔️ Verification
Manually tested with the frontend.
Test Changes
Updated the update cost test
🏕️ (Optional) Future Work / Notes
Error doesn't get shown in the fronted this should be fixed on sunday hopefully.