Skip to content

update user profile updates side effects#401

Open
camila-carrillo wants to merge 2 commits intomainfrom
396-dev-user-profile-updates-side-effects
Open

update user profile updates side effects#401
camila-carrillo wants to merge 2 commits intomainfrom
396-dev-user-profile-updates-side-effects

Conversation

@camila-carrillo
Copy link
Copy Markdown
Contributor

@camila-carrillo camila-carrillo commented Apr 9, 2026

ℹ️ Issue

Closes #396

📝 Description

Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.

Makes sure changes made to user profile are propagated appropriately to grants where that user is the BCAN POC. It is important so data stays consistent.

Briefly list the changes made to the code:

  1. Added updateGrantsByPOC method to grant.service.ts
  2. Exported GrantService from grant.module.ts and imported GrantModule into auth.module.ts so that AuthService can access GrantService
  3. Injected GrantService into AuthService and wired updateGrantsByPOC into existing updateProfile method
  4. Added fetchGrants call in Settings.tsx

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Started the app, logged in, changed my first name, last name, and email and made sure BCAN POC on appropriate grants updated properly.

Provide screenshots of any new components, styling changes, or pages.
n/a

Test Changes

If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.

  • existing auth service test updated to mock GrantService dependency

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!
We should make sure changes are propagated to notifications as well so that those notifications don't get orphaned.

@camila-carrillo camila-carrillo linked an issue Apr 9, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@janekamata janekamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be working for me. When I look at a BCAN contact on a grant the name doesn't update. It might be something that needs to change in ContactCard. The component isn't an observable currently so that could be a factor

@yumi520
Copy link
Copy Markdown
Contributor

yumi520 commented Apr 9, 2026

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV User profile updates side effects

3 participants