feat(ui): profiles list as rows + page-size 8 + settings/runtime cleanup#38
Merged
Merged
Conversation
Profile cards collapse to single-row list items so 8 accounts fit per page without scrolling on a typical window. Each row is `[name + plan]` on top with `[5h quota | weekly quota | actions]` underneath in one horizontal grid track, mirrored across base.css, mac/front/styles.css, and win/front/styles.css since mac/win still duplicate the shared selectors. Drops the unwired Runtime tab + page entirely (ShellRoute, route-tabs entry, `<section id="page-runtime">`) and centers the top nav. On the settings page, removes 4 placeholder rows that never had a backend (Forward port, Admin port, Launch at login, Configuration backup w/ backup/export/import) and squashes the Codex CLI path row from the two-line `--stacked` layout to a single inline row with the Change button on the right, with text-overflow ellipsis on long paths. Page size raised from 4 to 8: DEFAULT_PAGE_SIZE in shared/runtime/paths.rs, state.pageSize default, and the preview snapshot in tauri.ts. README.md / README.zh-CN.md / CHANGELOG.md (Unreleased) updated. Unused i18n keys + .runtime-grid / .settings-panel--runtime CSS left in place; they're harmless dead strings best swept in a follow-up cleanup.
Renames the Unreleased CHANGELOG section to 1.5.10. version-sync writes the new version into package.json / package-lock.json / src-tauri/Cargo.toml; Cargo.lock refreshed by `cargo check`.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89f63202f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
版本号已 bump 到 1.5.10（package.json / package-lock.json / Cargo.toml / Cargo.lock 同步），CHANGELOG 的 Unreleased 段重命名为 CI 跟踪已在后台轮询，全绿后告知。 需要 @Cmochance 完成的事项：
后续可选清理（不在本 PR 范围）：
|
The earlier bump only patched the literal inside refreshPreviewSnapshot();
the initial `let previewSnapshot = { page_size: 4, ... }` declaration was
left untouched because the indentation differed. In `!hasTauriRuntime`
preview mode the very first `get_profiles_snapshot` returns this literal
directly, so paging silently kept the old 4-per-page behaviour until a
mutating action ran. Caught by chatgpt-codex-connector review on PR #38.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name + planon top;5h quota | weekly quota | actionsin one horizontal track). 8 entries per page now (was 4);DEFAULT_PAGE_SIZEraised inpaths.rs+ matching frontend defaults.<section id="page-runtime">page; dropped"runtime"fromShellRoute.--stackedto a single inline row with the Change button on the right and ellipsis on long paths.CSS edits mirrored across
shared/front/base.css,mac/front/styles.css,win/front/styles.cssbecause the mac/win sheets currently re-declare the shared selectors. Cleaning up that duplication is a separate refactor.Unused i18n keys (
navRuntime,settingsForwardPort, …) and.runtime-grid/.settings-panel--runtimeCSS left in place — they're harmless dead strings and best swept in a follow-up.Test plan
npm run tauri:dev): account list renders as rows, 8 per page, paging works#runtimefalls back to dashboardtauri build --target x86_64-pc-windows-msvcsucceeds