Made mapping for all known table engines to a table types in JDBC #2737
+341
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
kurnoolsaketh
requested changes
Feb 9, 2026
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * Converts engine name to table type. Returns TABLE as default for unknown engines. |
There was a problem hiding this comment.
Returns TABLE as default for unknown engines.
if a user is trying to write use an unknown/undefined table engine, shouldn't the client throw an exception and prevent this behavior? Otherwise, their query will fail
Contributor
Author
There was a problem hiding this comment.
Users of older JDBC versions should be able to work with newer servers. Having unknown engine mapped to TABLE let user see them.
Showing error results blocking them until upgrade.
There was a problem hiding this comment.
understood - can you add this to the comment please?
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
| if (engine == null) { | ||
| return TableType.TABLE.getTypeName(); | ||
| } | ||
| // Check for system tables (engines starting with "System" or "Async") |
There was a problem hiding this comment.
what's an example of a table engine that starts with System or Async? I don't see any here: https://clickhouse.com/docs/engines/table-engines
Contributor
Author
There was a problem hiding this comment.
They are not listed but present in system database. Here are some.
SELECT
name,
database,
engine
FROM system.tables
WHERE startsWith(engine, 'System') OR startsWith(engine, 'Async')
Query id: da51240b-613a-4d2a-84b1-163298e2ad69
┌─name───────────────────────────┬─database─┬─engine─────────────────────────────┐
1. │ aggregate_function_combinators │ system │ SystemAggregateFunctionCombinators │
2. │ asynchronous_inserts │ system │ SystemAsynchronousInserts │
3. │ asynchronous_loader │ system │ SystemAsyncLoader │
4. │ asynchronous_metrics │ system │ SystemAsynchronousMetrics │
5. │ azure_queue │ system │ SystemAzureQueue │
6. │ azure_queue_settings │ system │ SystemAzureQueueSettings │
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
…lumn name with constant
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
|
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
Contributor
Author
|
the security issue will be addressed in #2739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2664
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Changes
DatabaseMetaDataImpl.getTables()filtering andTABLE_TYPEderivation based on engine/temporary/system rules, which can affect how clients discover objects; coverage is improved with new integration tests.Overview
Improves JDBC v2 table type reporting by adding
MATERIALIZED VIEWand introducing an explicitENGINE_TO_TABLE_TYPEmapping sogetTables()classifies ClickHouse objects by engine (including many remote/external engines) instead of a small set of heuristics.getTables()now uses prepared statements, builds an engine-based filter for the requested JDBC table types (including defaulting unknown engines toTABLE, special-casingSystem*/Async*, and handling temporary tables), and post-processes results via a mutator to return the final JDBCTABLE_TYPE.getTableTypes()is also parameterized and backed by the enum-derived list.Adds integration tests to validate type lists, per-type filtering behavior across representative objects (table/view/materialized view/dictionary/remote/system), and a guard test ensuring all engines in
system.table_enginesare mapped (or covered by the system/async prefix rule). Updates the performance module to use Testcontainers2.0.2and the renamedtestcontainers-clickhouseartifact.Written by Cursor Bugbot for commit 6eeaf08. This will update automatically on new commits. Configure here.