Rework UI#838
Open
rotmanjanez wants to merge 4 commits intoClickHouse:mainfrom
Open
Conversation
this also seems like a more interresting metric, as the other HTMLs did not seem to bother adding the combined few. This suggests that the hot-metric is mostly used and should be the default also here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I regularly look at the ClickBench website, and slowly, the selectors become more and more convoluted, and viewing the actual results becomes more annoying. This is an attempt to fix the UI experience of the online benchmark results websites.
Main Changes:
Databaseselector that buckets the different variations into more easily digestible selectors. The full systems selector is still in a dropdown.hotas their default. The HTML comparing different ClickHouse versions does not even implement thecombinedmetric. It does not seem very important to technical persons, who are likely the main visitors of the page. The first thing I do when I visit clickbench is to change to hot run only, and I know that I am not the only one doing this. I would be interested if anyone that actually uses this site on a regular basis looks at the combined metric and why.I tried to make old links with hashes still work, and from my limited testing, they still work as intended.
I hope you and others like the direction of this PR.