SDK-5762: Push template UI improvements and timer state persistence#57
SDK-5762: Push template UI improvements and timer state persistence#57reshab-code wants to merge 9 commits into
Conversation
[SDK-4686] Release v1.0.0
[SDK-4995] Release v1.1.0
[SDK-5574] Release v1.2.0
[SDK-5730] Release v1.3.0
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
reshab-code
force-pushed
the
task/SDK-5762-push-template-improvements
branch
from
a26983f to
a578335
Compare
| titleLabel.topAnchor.constraint(equalTo: contentView.topAnchor, constant: 8), | ||
| titleLabel.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: Constraints.kCaptionLeftPadding), | ||
| titleLabel.topAnchor.constraint(equalTo: contentView.topAnchor, constant: 16), | ||
| titleLabel.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: 16), |
There was a problem hiding this comment.
use constant here and other places
|
|
||
| subTitleLabel.topAnchor.constraint(equalTo: titleLabel.bottomAnchor, constant: 8), | ||
| subTitleLabel.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: Constraints.kCaptionLeftPadding), | ||
| subTitleLabel.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: 16), |
There was a problem hiding this comment.
can you try rendering with wrong image url and see if template looks fine? also test for case when rating is also not displayed along with wrong image url
| bigImageView.translatesAutoresizingMaskIntoConstraints = false | ||
| return bigImageView | ||
| }() | ||
| private let scrimView: UIView = { |
There was a problem hiding this comment.
what should be expected scrimView UI? Do you have any reference screenshot or screenshot from Android?
There was a problem hiding this comment.
Yes I checked with Anush for android and added scrim for the lower 30% part of the view for better text clarity
| } | ||
|
|
||
| func setupConstraints() { | ||
| let timerLabelWidth: CGFloat = thresholdSeconds >= 3600 |
There was a problem hiding this comment.
since we are updating constraints, check if we have long text in title and message, it goes behind the timer label, we should show ... at end before timer label. Also when timer comes below 3600, the width should decrease allowing more title texts
|
|
||
| var captionColor: String = ConstantKeys.kHexBlackColor | ||
| var subcaptionColor: String = ConstantKeys.kHexLightGrayColor | ||
| var captionColor: String = ConstantKeys.kHexWhiteColor |
There was a problem hiding this comment.
why have we changed caption color? If we need change, do we need to change dark color also?
3 participants
Summary