Fix. ContactEncoder. Edits made in the shortcode omitted from encoding#815
Open
AntonV1211 wants to merge 2 commits into
Open
Fix. ContactEncoder. Edits made in the shortcode omitted from encoding#815AntonV1211 wants to merge 2 commits into
AntonV1211 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #815 +/- ##
============================================
+ Coverage 26.46% 26.51% +0.04%
- Complexity 5667 5676 +9
============================================
Files 269 269
Lines 24240 24258 +18
============================================
+ Hits 6416 6432 +16
- Misses 17824 17826 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ContactsEncoder “skip encoding” shortcode handling to reduce XSS risk during shortcode decoding and to avoid processing shortcodes that appear inside HTML tag/attribute contexts.
Changes:
- Sanitizes shortcode callback output (escape decoded value; sanitize fallback HTML).
- Skips
changeContentAfterEncoderModify()processing when the shortcode appears inside an HTML tag/attribute context. - Adds PHPUnit coverage for sanitization behavior and for detecting shortcode offsets inside/outside HTML tags.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
lib/Cleantalk/ApbctWP/ContactsEncoder/Shortcodes/ExcludedEncodeContentSC.php |
Escapes decoded output, sanitizes fallback output, and adds HTML-tag-context detection to avoid unsafe processing. |
tests/ApbctWP/ContactsEncoder/Shortcodes/ExcludedEncodeContentSCTest.php |
Adds teardown cleanup plus tests for sanitization and HTML-tag-context detection/skip behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/49320